Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Issue 2386383002: Remove redundant check for whether WebappInfo#id or WebappInfo#uri are null (Closed)

Created:
4 years, 2 months ago by pkotwicz
Modified:
4 years, 2 months ago
Reviewers:
dominickn
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant check for whether WebappInfo#id or WebappInfo#uri are null WebappInfo#create() returns null if either the id or the uri are null BUG=None Committed: https://crrev.com/99f3799dd19f56a86165feaf9c848d65deedc9d5 Cr-Commit-Position: refs/heads/master@{#423652}

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into security00 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -31 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java View 1 2 chunks +30 lines, -31 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
pkotwicz
Dominick, can you please take a look?
4 years, 2 months ago (2016-10-03 23:18:14 UTC) #2
dominickn
lgtm, thanks.
4 years, 2 months ago (2016-10-04 01:01:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386383002/1
4 years, 2 months ago (2016-10-05 02:11:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/140242)
4 years, 2 months ago (2016-10-05 02:58:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386383002/1
4 years, 2 months ago (2016-10-06 19:20:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386383002/20001
4 years, 2 months ago (2016-10-06 19:32:08 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 20:25:03 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 20:28:17 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/99f3799dd19f56a86165feaf9c848d65deedc9d5
Cr-Commit-Position: refs/heads/master@{#423652}

Powered by Google App Engine
This is Rietveld 408576698