Issue 2386363002: Don't use Source to compute absolute URI in _getLibraryByRelativeUri().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2386363002: Don't use Source to compute absolute URI in _getLibraryByRelativeUri(). (Closed)

Created:
4 years, 2 months ago by scheglov

Modified:
4 years, 2 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Don't use Source to compute absolute URI in _getLibraryByRelativeUri(). It does not matter usually, unless we live in the environment where actual Source resolution is very expensive. This makes resynthsis about 10% faster in this case. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0c603e1bb962d82ae9ec144049cba4a1b02db880

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	pkg/analyzer/lib/src/summary/resynthesize.dart	View		2 chunks	+4 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years, 2 months ago (2016-10-04 15:23:31 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0c603e1bb962d82ae9ec144049cba4a1b02db880 (presubmit successful).