third_party/WebKit/Source/platform/fonts/android/FontCacheAndroidTest.cpp - Issue 2386333002: reflow comments in platform/fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/android/FontCacheAndroidTest.cpp

Issue 2386333002: reflow comments in platform/fonts (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/fonts/GlyphMetricsMap.h ('K') | « third_party/WebKit/Source/platform/fonts/UTF16TextIterator.cpp ('k') | third_party/WebKit/Source/platform/fonts/linux/FontCacheLinux.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/android/FontCacheAndroidTest.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/android/FontCacheAndroidTest.cpp b/third_party/WebKit/Source/platform/fonts/android/FontCacheAndroidTest.cpp

index df7c9dcae36996923c682e672b784ad0264af513..827c8dc0847204dd406adb8b04844077787ae2e9 100644

--- a/third_party/WebKit/Source/platform/fonts/android/FontCacheAndroidTest.cpp

+++ b/third_party/WebKit/Source/platform/fonts/android/FontCacheAndroidTest.cpp

@@ -35,7 +35,8 @@ TEST(FontCacheAndroid, genericFamilyNameForScript) {

if (FontFamilyNames::webkit_standard.isEmpty())

FontFamilyNames::init();

- // For non-CJK, getGenericFamilyNameForScript should return the given familyName.

+ // For non-CJK, getGenericFamilyNameForScript should return the given

+ // familyName.

EXPECT_EQ(FontFamilyNames::webkit_standard,

FontCache::getGenericFamilyNameForScript(

FontFamilyNames::webkit_standard, english));

@@ -43,7 +44,8 @@ TEST(FontCacheAndroid, genericFamilyNameForScript) {

FontCache::getGenericFamilyNameForScript(

FontFamilyNames::webkit_monospace, english));

- // For CJK, getGenericFamilyNameForScript should return CJK fonts except monospace.

+ // For CJK, getGenericFamilyNameForScript should return CJK fonts except

+ // monospace.

EXPECT_NE(FontFamilyNames::webkit_standard,

FontCache::getGenericFamilyNameForScript(

FontFamilyNames::webkit_standard, chinese));