chrome/browser/extensions/api/preference/preference_helpers.cc - Issue 238633009: cleanup: Use EventRouter instead of ExtensionSystem::Get->event_router()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/preference/preference_helpers.cc

Issue 238633009: cleanup: Use EventRouter instead of ExtensionSystem::Get->event_router() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix compile error for chromeos build. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/preference/preference_api.cc ('k') | chrome/browser/extensions/api/processes/processes_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/preference/preference_helpers.cc

diff --git a/chrome/browser/extensions/api/preference/preference_helpers.cc b/chrome/browser/extensions/api/preference/preference_helpers.cc

index fe55fd719453055d0add78792d275250360102b5..09b00f39ba85ddcbaba8d1650f3b176fa20c0a21 100644

--- a/chrome/browser/extensions/api/preference/preference_helpers.cc

+++ b/chrome/browser/extensions/api/preference/preference_helpers.cc

@@ -89,8 +89,7 @@ void DispatchEventToExtensions(

APIPermission::ID permission,

bool incognito,

const std::string& browser_pref) {

- EventRouter* router =

- ExtensionSystem::Get(profile)->event_router();

+ EventRouter* router = EventRouter::Get(profile);

if (!router || !router->HasEventListener(event_name))

return;

ExtensionService* extension_service =