Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Unified Diff: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

Issue 238633009: cleanup: Use EventRouter instead of ExtensionSystem::Get->event_router() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix compile error for chromeos build. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
diff --git a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
index 9fd285771df0274c0004ba56388ba9e448dbbdc5..a49ca16f10f5a41f398051593335b7eda9612d9c 100644
--- a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
+++ b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
@@ -44,7 +44,6 @@
#include "content/public/browser/web_contents_view.h"
#include "extensions/browser/event_router.h"
#include "extensions/browser/extension_function_dispatcher.h"
-#include "extensions/browser/extension_system.h"
#include "extensions/browser/quota_service.h"
#include "grit/generated_resources.h"
#include "ui/base/l10n/l10n_util.h"
@@ -173,11 +172,10 @@ BookmarkEventRouter::~BookmarkEventRouter() {
void BookmarkEventRouter::DispatchEvent(
const std::string& event_name,
scoped_ptr<base::ListValue> event_args) {
- if (extensions::ExtensionSystem::Get(browser_context_)->event_router()) {
- extensions::ExtensionSystem::Get(browser_context_)
- ->event_router()
- ->BroadcastEvent(make_scoped_ptr(
- new extensions::Event(event_name, event_args.Pass())));
+ EventRouter* event_router = EventRouter::Get(browser_context_);
+ if (event_router) {
+ event_router->BroadcastEvent(
+ make_scoped_ptr(new extensions::Event(event_name, event_args.Pass())));
}
}
@@ -289,8 +287,7 @@ void BookmarkEventRouter::ExtensiveBookmarkChangesEnded(BookmarkModel* model) {
BookmarksAPI::BookmarksAPI(BrowserContext* context)
: browser_context_(context) {
- EventRouter* event_router =
- ExtensionSystem::Get(browser_context_)->event_router();
+ EventRouter* event_router = EventRouter::Get(browser_context_);
event_router->RegisterObserver(this, bookmarks::OnCreated::kEventName);
event_router->RegisterObserver(this, bookmarks::OnRemoved::kEventName);
event_router->RegisterObserver(this, bookmarks::OnChanged::kEventName);
@@ -305,8 +302,7 @@ BookmarksAPI::~BookmarksAPI() {
}
void BookmarksAPI::Shutdown() {
- ExtensionSystem::Get(browser_context_)->event_router()->UnregisterObserver(
- this);
+ EventRouter::Get(browser_context_)->UnregisterObserver(this);
}
static base::LazyInstance<BrowserContextKeyedAPIFactory<BookmarksAPI> >
@@ -323,8 +319,7 @@ void BookmarksAPI::OnListenerAdded(const EventListenerInfo& details) {
browser_context_,
BookmarkModelFactory::GetForProfile(
Profile::FromBrowserContext(browser_context_))));
- ExtensionSystem::Get(browser_context_)->event_router()->UnregisterObserver(
- this);
+ EventRouter::Get(browser_context_)->UnregisterObserver(this);
}
bool BookmarksGetFunction::RunImpl() {

Powered by Google App Engine
This is Rietveld 408576698