OLD | NEW |
1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2011 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Presubmit script for changes affecting chrome/ | 5 """Presubmit script for changes affecting chrome/ |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
9 """ | 9 """ |
10 | 10 |
11 import re | 11 import re |
12 | 12 |
13 INCLUDE_CPP_FILES_ONLY = ( | 13 INCLUDE_CPP_FILES_ONLY = ( |
14 r'.*\.cc$', r'.*\.h$' | 14 r'.*\.cc$', r'.*\.h$' |
15 ) | 15 ) |
16 | 16 |
17 EXCLUDE = ( | 17 EXCLUDE = ( |
18 # Objective C confuses everything. | 18 # Objective C confuses everything. |
19 r'.*cocoa.*', | 19 r'.*cocoa.*', |
20 r'.*_mac\.(cc|h)$', | 20 r'.*_mac\.(cc|h)$', |
21 r'.*_mac_.*', | 21 r'.*_mac_.*', |
22 # All the messages files do weird multiple include trickery | 22 # All the messages files do weird multiple include trickery |
23 r'.*_messages.*\.h$', | 23 r'.*_messages.*\.h$', |
24 r'render_messages.h$', | 24 r'render_messages.h$', |
25 # Autogenerated window resources files are off limits | 25 # Autogenerated window resources files are off limits |
26 r'.*resource.h$', | 26 r'.*resource.h$', |
27 # GTK macros in C-ish header code cause false positives | |
28 r'gtk_.*\.h$', | |
29 # Header trickery | 27 # Header trickery |
30 r'.*-inl\.h$', | 28 r'.*-inl\.h$', |
31 # Templates | 29 # Templates |
32 r'sigslotrepeater\.h$', | 30 r'sigslotrepeater\.h$', |
33 # GCC attribute trickery | 31 # GCC attribute trickery |
34 r'sel_main\.cc$', | 32 r'sel_main\.cc$', |
35 # Mozilla code | 33 # Mozilla code |
36 r'mork_reader\.h$', | 34 r'mork_reader\.h$', |
37 r'mork_reader\.cc$', | 35 r'mork_reader\.cc$', |
38 r'nss_decryptor_linux\.cc$', | 36 r'nss_decryptor_linux\.cc$', |
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
80 def CheckChangeOnUpload(input_api, output_api): | 78 def CheckChangeOnUpload(input_api, output_api): |
81 results = [] | 79 results = [] |
82 results.extend(_CommonChecks(input_api, output_api)) | 80 results.extend(_CommonChecks(input_api, output_api)) |
83 results.extend(_CheckChangeLintsClean(input_api, output_api)) | 81 results.extend(_CheckChangeLintsClean(input_api, output_api)) |
84 return results | 82 return results |
85 | 83 |
86 def CheckChangeOnCommit(input_api, output_api): | 84 def CheckChangeOnCommit(input_api, output_api): |
87 results = [] | 85 results = [] |
88 results.extend(_CommonChecks(input_api, output_api)) | 86 results.extend(_CommonChecks(input_api, output_api)) |
89 return results | 87 return results |
OLD | NEW |