Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 238633004: Remove all uses of toolkit_use_gtk in the gyp files. (Closed)

Created:
6 years, 8 months ago by Elliot Glaysher
Modified:
6 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, sadrul, tfarina, jam, dcheng, feature-media-reviews_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Remove all uses of toolkit_use_gtk in the gyp files. BUG=297026 R=ben@chromium.org, brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264609

Patch Set 1 #

Patch Set 2 : Rebase to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -455 lines) Patch
M base/base.gyp View 1 5 chunks +1 line, -35 lines 0 comments Download
M build/all.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M build/build_config.h View 1 chunk +0 lines, -6 lines 0 comments Download
M build/common.gypi View 1 6 chunks +2 lines, -19 lines 0 comments Download
M build/filename_rules.gypi View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/PRESUBMIT.py View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -40 lines 0 comments Download
M chrome/browser/extensions/api/app_window/app_window_apitest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -39 lines 0 comments Download
M chrome/chrome_exe.gypi View 2 chunks +11 lines, -25 lines 0 comments Download
M chrome/chrome_tests.gypi View 6 chunks +5 lines, -16 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/nacl.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M courgette/courgette.gyp View 2 chunks +0 lines, -20 lines 0 comments Download
M gpu/command_buffer_service.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/gles2_conform_support/gles2_conform_support.gyp View 2 chunks +0 lines, -8 lines 0 comments Download
M ipc/ipc.gyp View 2 chunks +0 lines, -10 lines 0 comments Download
M jingle/jingle.gyp View 1 chunk +0 lines, -7 lines 0 comments Download
M media/media.gyp View 1 2 chunks +0 lines, -24 lines 0 comments Download
M net/net.gyp View 2 chunks +0 lines, -11 lines 0 comments Download
M printing/printing.gyp View 3 chunks +0 lines, -16 lines 0 comments Download
D tools/gtk_clipboard_dump/gtk_clipboard_dump.cc View 1 chunk +0 lines, -85 lines 0 comments Download
D tools/gtk_clipboard_dump/gtk_clipboard_dump.gyp View 1 chunk +0 lines, -14 lines 0 comments Download
M ui/base/ui_base.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D ui/gfx/gdk_compat.h View 1 chunk +0 lines, -27 lines 0 comments Download
M ui/resources/ui_resources.grd View 3 chunks +3 lines, -3 lines 0 comments Download
M ui/ui_unittests.gyp View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/views/metrics_aura.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/view_aura.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M webkit/common/webkit_common.gyp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Elliot Glaysher
6 years, 8 months ago (2014-04-16 20:26:15 UTC) #1
brettw
lgtm
6 years, 8 months ago (2014-04-16 20:53:20 UTC) #2
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 8 months ago (2014-04-16 21:33:17 UTC) #3
Elliot Glaysher
The CQ bit was unchecked by erg@chromium.org
6 years, 8 months ago (2014-04-16 21:33:19 UTC) #4
Elliot Glaysher
ben: top level owners stamp
6 years, 8 months ago (2014-04-16 21:34:27 UTC) #5
Ben Goodger (Google)
lgtm
6 years, 8 months ago (2014-04-16 21:35:13 UTC) #6
Elliot Glaysher
The CQ bit was checked by erg@chromium.org
6 years, 8 months ago (2014-04-16 21:36:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/238633004/20001
6 years, 8 months ago (2014-04-16 21:36:56 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-17 00:46:04 UTC) #9
commit-bot: I haz the power
Failed to apply patch for chrome/app/generated_resources.grd: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-17 00:46:04 UTC) #10
Elliot Glaysher
6 years, 8 months ago (2014-04-17 19:20:30 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 manually as r264609 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698