Issue 238633002: Web Animations API: Add runtime flag for minimal element.animate feature

Issue 238633002: Web Animations API: Add runtime flag for minimal element.animate feature (Closed)

Created:
6 years, 8 months ago by dstockwell

Modified:
6 years, 8 months ago

Reviewers:
shans, eseidel

CC:
blink-reviews, ed+blinkwatch_opera.com, shans, arv+blink, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, rune+blink, dglazkov+blink, Timothy Loh, apavlov+blink_chromium.org, Inactive, darktears, rjwright, Steve Block, dino_apple.com, watchdog-blink-watchlist_google.com, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Web Animations API: Add runtime flag for minimal element.animate feature Includes: * element.animate(sequence<Keyframe> effect, optional (double or TimingInput) timing) * [NoInterfaceObject] AnimationPlayer with only finish event and cancel() method BUG=327564 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171536

Patch Set 1 : #

Patch Set 2 : Update expectations. #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -17 lines)			Patch
M	LayoutTests/webexposed/global-constructors-listing-expected.txt	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/animation/AnimationPlayer.idl	View		1 chunk	+14 lines, -13 lines	1 comment	Download
M	Source/core/animation/ElementAnimation.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/parser/CSSPropertyParser.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/RuntimeEnabledFeatures.in	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

eseidel

https://codereview.chromium.org/238633002/diff/30001/Source/core/animation/AnimationPlayer.idl File Source/core/animation/AnimationPlayer.idl (right): https://codereview.chromium.org/238633002/diff/30001/Source/core/animation/AnimationPlayer.idl#newcode33 Source/core/animation/AnimationPlayer.idl:33: NoInterfaceObject, Was NoInterfaceObject intentional?

6 years, 8 months ago (2014-04-15 05:40:43 UTC) #3

dstockwell

On 2014/04/15 05:40:43, eseidel wrote: > https://codereview.chromium.org/238633002/diff/30001/Source/core/animation/AnimationPlayer.idl > File Source/core/animation/AnimationPlayer.idl (right): > > https://codereview.chromium.org/238633002/diff/30001/Source/core/animation/AnimationPlayer.idl#newcode33 > ...

6 years, 8 months ago (2014-04-15 05:42:54 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/238633002/30001

6 years, 8 months ago (2014-04-15 05:54:28 UTC) #7

nduca

6 years, 8 months ago (2014-04-15 17:01:19 UTC) #9

Message was sent while issue was closed.

Should we switch --enable-bleeding-edge-rendering-fast-paths to use this instead
of full webanim?

Expand Messages | Collapse Messages