|
|
DescriptionTry re-enabling a load-and-launch browser test for win & linux
BUG=176897
Committed: https://crrev.com/9c7cba54c3154ccd52e51b0a14f3fd04e093a6de
Cr-Commit-Position: refs/heads/master@{#422833}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 19 (9 generated)
Description was changed from ========== Re-enable load-and-launch browser test for win & linux BUG=624098 ========== to ========== Re-enable a load-and-launch browser test for win & linux BUG=624098 ==========
proberge@chromium.org changed reviewers: + msw@chromium.org
Test re-enabling I had promised back in https://codereview.chromium.org/2108853002.
lgtm with a nit https://codereview.chromium.org/2386313003/diff/1/apps/load_and_launch_browse... File apps/load_and_launch_browsertest.cc (left): https://codereview.chromium.org/2386313003/diff/1/apps/load_and_launch_browse... apps/load_and_launch_browsertest.cc:176: // http://crbug.com/176897 nit: mention BUG=176897 (and close that bug if this sticks).
Description was changed from ========== Re-enable a load-and-launch browser test for win & linux BUG=624098 ========== to ========== Try re-enabling a load-and-launch browser test for win & linux BUG=176897 ==========
https://codereview.chromium.org/2386313003/diff/1/apps/load_and_launch_browse... File apps/load_and_launch_browsertest.cc (left): https://codereview.chromium.org/2386313003/diff/1/apps/load_and_launch_browse... apps/load_and_launch_browsertest.cc:176: // http://crbug.com/176897 On 2016/10/03 21:16:52, msw wrote: > nit: mention BUG=176897 (and close that bug if this sticks). Done.
The CQ bit was checked by proberge@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
proberge@chromium.org changed reviewers: + asargent@chromium.org
+asargent for apps/ owners
lgtm
The CQ bit was checked by proberge@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Try re-enabling a load-and-launch browser test for win & linux BUG=176897 ========== to ========== Try re-enabling a load-and-launch browser test for win & linux BUG=176897 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Try re-enabling a load-and-launch browser test for win & linux BUG=176897 ========== to ========== Try re-enabling a load-and-launch browser test for win & linux BUG=176897 Committed: https://crrev.com/9c7cba54c3154ccd52e51b0a14f3fd04e093a6de Cr-Commit-Position: refs/heads/master@{#422833} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9c7cba54c3154ccd52e51b0a14f3fd04e093a6de Cr-Commit-Position: refs/heads/master@{#422833} |