Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 2386313003: Re-enable a load-and-launch browser test for win & linux (Closed)

Created:
4 years, 2 months ago by proberge
Modified:
4 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try re-enabling a load-and-launch browser test for win & linux BUG=176897 Committed: https://crrev.com/9c7cba54c3154ccd52e51b0a14f3fd04e093a6de Cr-Commit-Position: refs/heads/master@{#422833}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M apps/load_and_launch_browsertest.cc View 1 chunk +1 line, -12 lines 2 comments Download

Messages

Total messages: 19 (9 generated)
proberge
Test re-enabling I had promised back in https://codereview.chromium.org/2108853002.
4 years, 2 months ago (2016-10-03 21:12:21 UTC) #3
msw
lgtm with a nit https://codereview.chromium.org/2386313003/diff/1/apps/load_and_launch_browsertest.cc File apps/load_and_launch_browsertest.cc (left): https://codereview.chromium.org/2386313003/diff/1/apps/load_and_launch_browsertest.cc#oldcode176 apps/load_and_launch_browsertest.cc:176: // http://crbug.com/176897 nit: mention BUG=176897 ...
4 years, 2 months ago (2016-10-03 21:16:52 UTC) #4
proberge
https://codereview.chromium.org/2386313003/diff/1/apps/load_and_launch_browsertest.cc File apps/load_and_launch_browsertest.cc (left): https://codereview.chromium.org/2386313003/diff/1/apps/load_and_launch_browsertest.cc#oldcode176 apps/load_and_launch_browsertest.cc:176: // http://crbug.com/176897 On 2016/10/03 21:16:52, msw wrote: > nit: ...
4 years, 2 months ago (2016-10-04 13:31:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386313003/1
4 years, 2 months ago (2016-10-04 13:32:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/273016)
4 years, 2 months ago (2016-10-04 13:43:47 UTC) #10
proberge
+asargent for apps/ owners
4 years, 2 months ago (2016-10-04 13:45:14 UTC) #12
asargent_no_longer_on_chrome
lgtm
4 years, 2 months ago (2016-10-04 16:57:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386313003/1
4 years, 2 months ago (2016-10-04 17:02:35 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 17:08:02 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 17:10:44 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c7cba54c3154ccd52e51b0a14f3fd04e093a6de
Cr-Commit-Position: refs/heads/master@{#422833}

Powered by Google App Engine
This is Rietveld 408576698