Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2386313002:
X11: Fix broken DCHECK when no transparent visual is available (Closed)
|
Created:
4 years, 2 months ago by Tom (Use chromium acct) Modified:
4 years, 2 months ago CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, hubbe Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionX11: Fix broken DCHECK when no transparent visual is available
BUG=347333, 369209, 640170
Committed: https://crrev.com/47138793372b148d80ad28d13580ba44d35daf16
Cr-Commit-Position: refs/heads/master@{#422525}
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 18 (12 generated)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Description was changed from ========== Fix broken DCHECK when no transparent visual is available ========== to ========== X11: Fix broken DCHECK when no transparent visual is available ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== X11: Fix broken DCHECK when no transparent visual is available ========== to ========== X11: Fix broken DCHECK when no transparent visual is available BUG=347333, 369209, 640170, 640170 ==========
Description was changed from ========== X11: Fix broken DCHECK when no transparent visual is available BUG=347333, 369209, 640170, 640170 ========== to ========== X11: Fix broken DCHECK when no transparent visual is available BUG=347333, 369209, 640170 ==========
thomasanderson@google.com changed reviewers: + derat@chromium.org
lgtm if it fixes the issue!
hubbe@chromium.org changed reviewers: + hubbe@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== X11: Fix broken DCHECK when no transparent visual is available BUG=347333, 369209, 640170 ========== to ========== X11: Fix broken DCHECK when no transparent visual is available BUG=347333, 369209, 640170 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== X11: Fix broken DCHECK when no transparent visual is available BUG=347333, 369209, 640170 ========== to ========== X11: Fix broken DCHECK when no transparent visual is available BUG=347333, 369209, 640170 Committed: https://crrev.com/47138793372b148d80ad28d13580ba44d35daf16 Cr-Commit-Position: refs/heads/master@{#422525} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/47138793372b148d80ad28d13580ba44d35daf16 Cr-Commit-Position: refs/heads/master@{#422525} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
