Issue 23863002: Refactoring: toHTMLElement(const Node*) added but never used. Using it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23863002: Refactoring: toHTMLElement(const Node*) added but never used. Using it. (Closed)

Created:
7 years, 3 months ago by r.kasibhatla

Modified:
7 years, 3 months ago

Reviewers:
tkent

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Refactoring: toHTMLElement(const Node*) added but never used. Using it. There is a const HTMLElement* toHTMLElement(const Node*) interface defined, but never used. Instead the static_cast is still used for this conversion. Replacing the static_cast to toHTMLElement call. BUG=None TEST=None. No functionality changed/effected. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157078

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -6 lines)			Patch
M	Source/core/editing/MarkupAccumulator.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/ReplaceSelectionCommand.cpp	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	Source/core/editing/markup.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLElement.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/23863002/1

7 years, 3 months ago (2013-09-02 09:17:05 UTC) #3

Message was sent while issue was closed.

Change committed as 157078

Expand Messages | Collapse Messages