Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2386293002: Add GMs for Analytic Anti-Aliasing (Closed)

Created:
4 years, 2 months ago by liyuqian
Modified:
4 years, 2 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add GMs for Analytic Anti-Aliasing #

Patch Set 3 : Comments #

Patch Set 4 : SkScalar #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -0 lines) Patch
A gm/aaa.cpp View 1 2 3 1 chunk +59 lines, -0 lines 2 comments Download
M gm/addarc.cpp View 1 2 1 chunk +53 lines, -0 lines 2 comments Download

Messages

Total messages: 19 (10 generated)
liyuqian
Make a small CL for GMs to reduce the size of our giant AnalyticAA CL.
4 years, 2 months ago (2016-10-03 19:25:10 UTC) #5
reed1
lgtm
4 years, 2 months ago (2016-10-03 19:46:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386293002/40001
4 years, 2 months ago (2016-10-03 19:48:37 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/12104)
4 years, 2 months ago (2016-10-03 19:55:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386293002/2
4 years, 2 months ago (2016-10-03 20:06:38 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:2) as https://skia.googlesource.com/skia/+/e60d85597f803c4dff6329840215af1d1d9a8fdc
4 years, 2 months ago (2016-10-03 20:49:40 UTC) #15
robertphillips
https://codereview.chromium.org/2386293002/diff/2/gm/aaa.cpp File gm/aaa.cpp (right): https://codereview.chromium.org/2386293002/diff/2/gm/aaa.cpp#newcode1 gm/aaa.cpp:1: /* 2014 ? https://codereview.chromium.org/2386293002/diff/2/gm/addarc.cpp File gm/addarc.cpp (right): https://codereview.chromium.org/2386293002/diff/2/gm/addarc.cpp#newcode187 gm/addarc.cpp:187: ...
4 years, 2 months ago (2016-10-07 14:12:46 UTC) #17
liyuqian
https://codereview.chromium.org/2386293002/diff/2/gm/aaa.cpp File gm/aaa.cpp (right): https://codereview.chromium.org/2386293002/diff/2/gm/aaa.cpp#newcode1 gm/aaa.cpp:1: /* On 2016/10/07 14:12:46, robertphillips wrote: > 2014 ? ...
4 years, 2 months ago (2016-10-07 14:15:50 UTC) #18
robertphillips
4 years, 2 months ago (2016-10-07 14:21:05 UTC) #19
Message was sent while issue was closed. 
On 2016/10/07 14:15:50, liyuqian wrote:
> https://codereview.chromium.org/2386293002/diff/2/gm/aaa.cpp
> File gm/aaa.cpp (right):
> 
> https://codereview.chromium.org/2386293002/diff/2/gm/aaa.cpp#newcode1
> gm/aaa.cpp:1: /*
> On 2016/10/07 14:12:46, robertphillips wrote:
> > 2014 ?
> 
> Ah, sorry that I forget to change this to 2016... Is this critical?
> 
> https://codereview.chromium.org/2386293002/diff/2/gm/addarc.cpp
> File gm/addarc.cpp (right):
> 
> https://codereview.chromium.org/2386293002/diff/2/gm/addarc.cpp#newcode187
> gm/addarc.cpp:187: 
> On 2016/10/07 14:12:46, robertphillips wrote:
> > Don't we just know strokeWidth is SK_Scalar1 / 2 (aka SK_ScalarHalf) ?
> 
> Yes, I was just copying from the StrokeCircleGM which does the same strange
> thing...

Just nits - ignore at will.

Powered by Google App Engine
This is Rietveld 408576698