Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2386273004: Add ptr_util.h from base until std::make_unique<> available (Closed)

Created:
4 years, 2 months ago by Tom Sepez
Modified:
4 years, 2 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Add ptr_util.h from base until std::make_unique<> available Committed: https://pdfium.googlesource.com/pdfium/+/36eb4bdcae719cf33c536ff72ac000482aed8382

Patch Set 1 #

Total comments: 2

Patch Set 2 : 2016 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -94 lines) Patch
M core/fpdfapi/fpdf_font/cpdf_font.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cfdf_document.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_document.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M core/fpdfdoc/cpdf_annot.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M core/fxcrt/fx_memory.h View 1 chunk +0 lines, -6 lines 0 comments Download
M core/fxcrt/fx_xml_parser.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M core/fxge/agg/fx_agg_driver.cpp View 7 chunks +11 lines, -10 lines 0 comments Download
M core/fxge/apple/fx_quartz_device.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M core/fxge/dib/fx_dib_engine.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M core/fxge/dib/fx_dib_main.cpp View 5 chunks +8 lines, -7 lines 0 comments Download
M core/fxge/dib/fx_dib_transform.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M core/fxge/ge/cfx_font.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M core/fxge/ge/cfx_fontmgr.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M core/fxge/win32/fx_win32_device.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_document.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M fpdfsdk/cpdfsdk_environment.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M fpdfsdk/cpdfsdk_pageview.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_listbox.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M fpdfsdk/formfiller/cffl_textfield.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M fpdfsdk/fpdf_dataavail.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M fpdfsdk/fpdf_ext.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M fpdfsdk/fpdf_progressive.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M fpdfsdk/fpdfdoc_unittest.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M fpdfsdk/fpdfeditimg.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M fpdfsdk/fpdfview.cpp View 8 chunks +14 lines, -13 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_app.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_page.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M fpdfsdk/fxedit/fxet_edit.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M fpdfsdk/javascript/JS_Runtime_Stub.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_FontMap.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_ListBox.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Wnd.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M testing/js_embedder_test.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/base/ptr_util.h View 1 1 chunk +74 lines, -0 lines 0 comments Download
M xfa/fde/xml/cfx_saxreader.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Tom Sepez
Dan, Lei, for review.
4 years, 2 months ago (2016-10-03 21:27:32 UTC) #4
Lei Zhang
lgtm https://codereview.chromium.org/2386273004/diff/1/third_party/base/ptr_util.h File third_party/base/ptr_util.h (right): https://codereview.chromium.org/2386273004/diff/1/third_party/base/ptr_util.h#newcode1 third_party/base/ptr_util.h:1: // Copyright 2015 The Chromium Authors. All rights ...
4 years, 2 months ago (2016-10-03 21:39:18 UTC) #5
Tom Sepez
https://codereview.chromium.org/2386273004/diff/1/third_party/base/ptr_util.h File third_party/base/ptr_util.h (right): https://codereview.chromium.org/2386273004/diff/1/third_party/base/ptr_util.h#newcode1 third_party/base/ptr_util.h:1: // Copyright 2015 The Chromium Authors. All rights reserved. ...
4 years, 2 months ago (2016-10-03 21:43:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386273004/20001
4 years, 2 months ago (2016-10-03 21:44:01 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 22:24:45 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/36eb4bdcae719cf33c536ff72ac000482aed...

Powered by Google App Engine
This is Rietveld 408576698