Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2386263004: Revert of Enable per thread heap on SharedWorker (Closed)

Created:
4 years, 2 months ago by keishi
Modified:
4 years, 2 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, shimazu+worker_chromium.org, falken, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable per thread heap on SharedWorker (patchset #1 id:1 of https://codereview.chromium.org/2374693002/ ) Reason for revert: Caused crashes crbug.com/652058 crbug.com/651702 crbug.com/652001 crbug.com/652264 crbug.com/652183 crbug.com/652556 Original issue's description: > Enable per thread heap on SharedWorker > > blink-dev PSA email: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wROZOp-YKSc > > BUG=591606 > > Committed: https://crrev.com/62d4e2e8f5ca66516854cbdbd1402d344410ec75 > Cr-Commit-Position: refs/heads/master@{#421731} TBR=oilpan-reviews@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=591606 Committed: https://crrev.com/e01a95ada6400bcba59f521d336cfe2909c7b929 Cr-Commit-Position: refs/heads/master@{#423122}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/workers/SharedWorkerThread.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
keishi
Created Revert of Enable per thread heap on SharedWorker
4 years, 2 months ago (2016-10-05 04:32:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386263004/1
4 years, 2 months ago (2016-10-05 04:33:19 UTC) #3
haraken
LGTM
4 years, 2 months ago (2016-10-05 04:37:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386263004/40001
4 years, 2 months ago (2016-10-05 07:09:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/154330)
4 years, 2 months ago (2016-10-05 08:29:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386263004/40001
4 years, 2 months ago (2016-10-05 09:30:17 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-05 09:58:16 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 10:00:24 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e01a95ada6400bcba59f521d336cfe2909c7b929
Cr-Commit-Position: refs/heads/master@{#423122}

Powered by Google App Engine
This is Rietveld 408576698