Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2386263002: Don't pixel-snap box size before applying transform to it. (Closed)

Created:
4 years, 2 months ago by chrishtr
Modified:
4 years, 2 months ago
Reviewers:
Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't pixel-snap box size before applying percentage transform to it. Otherwise we'll end up with error that gets larger according to the percentage. Note that subpixel accumulation is already plumbed through for transforms in other ways. BUG=627588 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/234079c8f5478894d70b6899a7461caa7062504d Cr-Commit-Position: refs/heads/master@{#422680}

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Messages

Total messages: 25 (20 generated)
chrishtr
4 years, 2 months ago (2016-10-03 22:55:00 UTC) #16
Xianzhu
lgtm
4 years, 2 months ago (2016-10-04 02:43:24 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386263002/40001
4 years, 2 months ago (2016-10-04 02:43:49 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-04 02:50:31 UTC) #23
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 02:54:16 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/234079c8f5478894d70b6899a7461caa7062504d
Cr-Commit-Position: refs/heads/master@{#422680}

Powered by Google App Engine
This is Rietveld 408576698