Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2386243002: Add in product messaging for IT Admins on chrome:policy (Closed)

Created:
4 years, 2 months ago by Georges Khalil
Modified:
4 years, 2 months ago
Reviewers:
Cait (Slow), Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org, blumberg
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add in product messaging for IT Admins on chrome:policy. BUG=652356 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f02848b7ff48e121c7302c2fdb58cb243816db65 Cr-Commit-Position: refs/heads/master@{#422789}

Patch Set 1 #

Total comments: 5

Patch Set 2 : dbeam@ comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M chrome/browser/resources/policy.css View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/policy.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/policy_ui.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/policy_strings.grdp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Georges Khalil
caitkp@chromium.org: Please review changes in components/policy_strings.grdp dbeam@chromium.org: Please review changes in chrome/browser/resources/*
4 years, 2 months ago (2016-10-03 19:29:57 UTC) #6
Dan Beam
lgtm https://codereview.chromium.org/2386243002/diff/20001/chrome/browser/resources/policy.css File chrome/browser/resources/policy.css (right): https://codereview.chromium.org/2386243002/diff/20001/chrome/browser/resources/policy.css#newcode82 chrome/browser/resources/policy.css:82: padding-left: 25px; -webkit-padding-start: 25px; so it magically flips ...
4 years, 2 months ago (2016-10-03 21:56:56 UTC) #7
Cait (Slow)
lgtm
4 years, 2 months ago (2016-10-04 13:36:18 UTC) #8
Georges Khalil
Thanks for the reviews. Sending to CQ. https://codereview.chromium.org/2386243002/diff/20001/chrome/browser/resources/policy.css File chrome/browser/resources/policy.css (right): https://codereview.chromium.org/2386243002/diff/20001/chrome/browser/resources/policy.css#newcode82 chrome/browser/resources/policy.css:82: padding-left: 25px; ...
4 years, 2 months ago (2016-10-04 13:36:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386243002/40001
4 years, 2 months ago (2016-10-04 13:37:16 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-04 14:41:29 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 14:44:40 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f02848b7ff48e121c7302c2fdb58cb243816db65
Cr-Commit-Position: refs/heads/master@{#422789}

Powered by Google App Engine
This is Rietveld 408576698