Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2386233002: ValueSerializer: Expose reading/writing doubles to embedder. (Closed)

Created:
4 years, 2 months ago by jbroman
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ValueSerializer: Expose reading/writing doubles to embedder. BUG=chromium:148757 Committed: https://crrev.com/5fa2734d39bd14116695e73a8ea7042a9e010a5a Cr-Commit-Position: refs/heads/master@{#39955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -1 line) Patch
M include/v8.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/api.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M src/value-serializer.h View 3 chunks +2 lines, -1 line 0 comments Download
M src/value-serializer.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M test/unittests/value-serializer-unittest.cc View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jbroman
4 years, 2 months ago (2016-10-03 18:06:33 UTC) #6
Camillo Bruni
lgtm
4 years, 2 months ago (2016-10-04 08:55:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386233002/1
4 years, 2 months ago (2016-10-04 13:41:06 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 13:44:26 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 13:44:55 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5fa2734d39bd14116695e73a8ea7042a9e010a5a
Cr-Commit-Position: refs/heads/master@{#39955}

Powered by Google App Engine
This is Rietveld 408576698