Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2386213004: Use task id to determine if Preferences should be finished (Closed)

Created:
4 years, 2 months ago by Theresa
Modified:
4 years, 2 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use task id to determine if Preferences should be finished Use the taskId rather to determine if finish() should be called on Preferences. Previously, if a user navigated in Preferences, sResumedInstance got set to the sub-Preference and the main Preference got finished. Since they belong to the same task, this shouldn't happen. BUG=652572 Committed: https://crrev.com/0bf2743d7bc9a79573e15419dcb88ed111ff905b Cr-Commit-Position: refs/heads/master@{#422862}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Theresa
ptal
4 years, 2 months ago (2016-10-04 17:34:21 UTC) #3
Ted C
lgtm
4 years, 2 months ago (2016-10-04 17:40:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386213004/1
4 years, 2 months ago (2016-10-04 18:18:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 18:24:31 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 18:27:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0bf2743d7bc9a79573e15419dcb88ed111ff905b
Cr-Commit-Position: refs/heads/master@{#422862}

Powered by Google App Engine
This is Rietveld 408576698