Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Issue 2386213003: [MD settings] change icon on sync settings row (Closed)

Created:
4 years, 2 months ago by dschuyler
Modified:
4 years, 2 months ago
Reviewers:
Moe
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] change icon on sync settings row This CL changes the icon on the sync settings row to a right arrow. BUG=652349 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/96b14906470ce5a780577b133a517fd24a4653af Cr-Commit-Position: refs/heads/master@{#422527}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/people_page/people_page.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
dschuyler
4 years, 2 months ago (2016-10-03 19:11:26 UTC) #5
Moe
On 2016/10/03 19:11:26, dschuyler wrote: LGTM
4 years, 2 months ago (2016-10-03 19:39:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386213003/1
4 years, 2 months ago (2016-10-03 20:57:44 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 21:05:24 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 21:08:43 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96b14906470ce5a780577b133a517fd24a4653af
Cr-Commit-Position: refs/heads/master@{#422527}

Powered by Google App Engine
This is Rietveld 408576698