Reflow comments in Source/modules/speech and platform/speech

Reflow comments in Source/modules/speech and platform/speech

Context: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/xGUEAYEB9dc

BUG=563793
Committed: https://crrev.com/3704c018a0c4f287daa5aa0ce6fdbdf6444fcd49
Cr-Commit-Position: refs/heads/master@{#422644}

[hans, 2016-10-03 16:51:58]

Description was changed from

==========
Reflow comments in Source/modules/speech

BUG=563793
==========

to

==========
Reflow comments in Source/modules/speech

Context:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/xGUEAYEB9dc

BUG=563793
==========

[hans, 2016-10-03 16:52:16]

hans@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[hans, 2016-10-03 16:52:17]

Please take a look.

[hans, 2016-10-03 16:54:45]

Description was changed from

==========
Reflow comments in Source/modules/speech

Context:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/xGUEAYEB9dc

BUG=563793
==========

to

==========
Reflow comments in Source/modules/speech and platform/speech

Context:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/xGUEAYEB9dc

BUG=563793
==========

[Nico, 2016-10-03 17:03:02]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-10-03 17:03:03]

https://codereview.chromium.org/2386203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/speech/SpeechRecognition.cpp (right):

https://codereview.chromium.org/2386203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/speech/SpeechRecognition.cpp:170: ,
move this , after the m_grammars initializer

https://codereview.chromium.org/2386203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp (right):

https://codereview.chromium.org/2386203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp:78: // This state
is independent of whether the utterance happens to be paused.
nit: put on previous line?

https://codereview.chromium.org/2386203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp
(right):

https://codereview.chromium.org/2386203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp:60: // to
go from the platform voice back to the speech synthesis voice in the
put on previous line

https://codereview.chromium.org/2386203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h
(right):

https://codereview.chromium.org/2386203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h:87: // up
this needs lots of reflowing (hit gq a few times)

[hans, 2016-10-03 17:33:54]

Comments addressed; please take another look.

https://codereview.chromium.org/2386203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/speech/SpeechRecognition.cpp (right):

https://codereview.chromium.org/2386203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/speech/SpeechRecognition.cpp:170: ,
On 2016/10/03 17:03:02, Nico wrote:
> move this , after the m_grammars initializer

Done.

https://codereview.chromium.org/2386203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp (right):

https://codereview.chromium.org/2386203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp:78: // This state
is independent of whether the utterance happens to be paused.
On 2016/10/03 17:03:02, Nico wrote:
> nit: put on previous line?

Done.

https://codereview.chromium.org/2386203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp
(right):

https://codereview.chromium.org/2386203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp:60: // to
go from the platform voice back to the speech synthesis voice in the
On 2016/10/03 17:03:02, Nico wrote:
> put on previous line

Done.

https://codereview.chromium.org/2386203002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h
(right):

https://codereview.chromium.org/2386203002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h:87: // up
On 2016/10/03 17:03:03, Nico wrote:
> this needs lots of reflowing (hit gq a few times)

Done.

[Nico, 2016-10-03 17:35:42]

lgtm, thanks (I'm not an owner in modules, only in platform though, so dmazzoni
must stamp too)

[haraken, 2016-10-03 22:08:21]

LGTM

[Nico, 2016-10-03 22:10:27]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2016-10-03 22:11:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2016-10-03 22:24:35]

lgtm

[commit-bot: I haz the power, 2016-10-04 01:01:39]

Description was changed from

==========
Reflow comments in Source/modules/speech and platform/speech

Context:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/xGUEAYEB9dc

BUG=563793
==========

to

==========
Reflow comments in Source/modules/speech and platform/speech

Context:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/xGUEAYEB9dc

BUG=563793
==========

[commit-bot: I haz the power, 2016-10-04 01:01:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-04 01:04:31]

Description was changed from

==========
Reflow comments in Source/modules/speech and platform/speech

Context:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/xGUEAYEB9dc

BUG=563793
==========

to

==========
Reflow comments in Source/modules/speech and platform/speech

Context:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/xGUEAYEB9dc

BUG=563793

Committed: https://crrev.com/3704c018a0c4f287daa5aa0ce6fdbdf6444fcd49
Cr-Commit-Position: refs/heads/master@{#422644}
==========

[commit-bot: I haz the power, 2016-10-04 01:04:32]

Patchset 3 (id:??) landed as
https://crrev.com/3704c018a0c4f287daa5aa0ce6fdbdf6444fcd49
Cr-Commit-Position: refs/heads/master@{#422644}