Make all PermissionDecisionAutoBlocker methods static.

chrome/browser/permissions/permission_context_base.cc

Index: chrome/browser/permissions/permission_context_base.cc
diff --git a/chrome/browser/permissions/permission_context_base.cc b/chrome/browser/permissions/permission_context_base.cc
index 8e0e4ee83e3697a44fe5870c92d1c88955b8ffd9..92909556a1819b10add64a542004958fb5ea1287 100644
--- a/chrome/browser/permissions/permission_context_base.cc
+++ b/chrome/browser/permissions/permission_context_base.cc
@@ -48,7 +48,6 @@ PermissionContextBase::PermissionContextBase(
     const content::PermissionType permission_type,
     const ContentSettingsType content_settings_type)
     : profile_(profile),
-      decision_auto_blocker_(new PermissionDecisionAutoBlocker(profile)),
       permission_type_(permission_type),
       content_settings_type_(content_settings_type),
       weak_factory_(this) {
@@ -56,6 +55,7 @@ PermissionContextBase::PermissionContextBase(
   permission_queue_controller_.reset(new PermissionQueueController(
       profile_, permission_type_, content_settings_type_));
 #endif
+  PermissionDecisionAutoBlocker::UpdateFromVariations();

[kcarattini, 2016/10/04 05:26:05]

How often do you expect the value to change? You could alternatively call this
at the top of each of the  PermissionDecisionAutoBlocker static methods to
ensure they use the most up-to-date value. Might be overkill if that's not so
important.

[dominickn, 2016/10/04 06:18:54]

I think having it within PermissionContextBase makes the most amount of sense
overhead-wise. This shouldn't change all that often, but we need to call it more
often than browser startup for people who restart rarely.

[raymes, 2016/10/05 05:02:32]

This will only really happen once at browser (profile) startup. Maybe that's
good enough though.

[dominickn, 2016/10/05 05:55:30]

Acknowledged.

 }
 
 PermissionContextBase::~PermissionContextBase() {
@@ -238,8 +238,8 @@ void PermissionContextBase::PermissionDecided(
   // Check if we should convert a dismiss decision into a block decision. This
   // is gated on enabling the kBlockPromptsIfDismissedOften feature.
   if (content_setting == CONTENT_SETTING_DEFAULT &&
-      decision_auto_blocker_->ShouldChangeDismissalToBlock(requesting_origin,
-                                                           permission_type_)) {
+      PermissionDecisionAutoBlocker::ShouldChangeDismissalToBlock(
+          requesting_origin, permission_type_, profile_)) {
     persist = true;
     content_setting = CONTENT_SETTING_BLOCK;
   }