[wasm] Call a runtime function for a MemorySize instruction.

[wasm] Call a runtime function for a MemorySize instruction.

The implementation of MemorySize with RelocatableInt32Constants is
problematic if MemorySize is placed close to a GrowMemory instruction in
the code. The use of a runtime function guarantees that the order in
which MemorySize and GrowMemory is executed is correct.

R=titzer@chromium.org
BUG=chromium:651961
TEST=mjsunit/regress/wasm/regression-651961

Committed: https://crrev.com/2c12a9a42d454a36fcd2931fa458d72832eeb689
Committed: https://crrev.com/aa93e6ca95123ccd176c392a2b5b8772ee5eb5c4
Cr-Original-Commit-Position: refs/heads/master@{#39972}
Cr-Commit-Position: refs/heads/master@{#39980}

[ahaas, 2016-10-04 12:00:54]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 12:01:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2016-10-04 12:11:05]

On 2016/10/04 12:00:52, ahaas wrote:

lgtm

[commit-bot: I haz the power, 2016-10-04 12:18:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 12:18:32]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[ahaas, 2016-10-04 12:36:30]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 12:36:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-10-04 12:37:56]

On 2016/10/04 at 12:11:05, titzer wrote:
> On 2016/10/04 12:00:52, ahaas wrote:
> 
> lgtm

I had to move tests the MemorySize instruction from test-run-wasm.cc to
test-run-wasm-module.cc because test-run-wasm cannot deal with runtime calls.

[commit-bot: I haz the power, 2016-10-04 13:04:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 13:04:19]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-10-05 06:04:23]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-10-05 06:04:24]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2386183004/#ps20001
(title: "test-run-wasm cannot do runtime calls")

[commit-bot: I haz the power, 2016-10-05 06:04:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 06:06:51]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 06:07:07]

Description was changed from

==========
[wasm] Call a runtime function for a MemorySize instruction.

The implementation of MemorySize with RelocatableInt32Constants is
problematic if MemorySize is placed close to a GrowMemory instruction in
the code. The use of a runtime function guarantees that the order in
which MemorySize and GrowMemory is executed is correct.

R=titzer@chromium.org
BUG=chromium:651961
TEST=mjsunit/regress/wasm/regression-651961
==========

to

==========
[wasm] Call a runtime function for a MemorySize instruction.

The implementation of MemorySize with RelocatableInt32Constants is
problematic if MemorySize is placed close to a GrowMemory instruction in
the code. The use of a runtime function guarantees that the order in
which MemorySize and GrowMemory is executed is correct.

R=titzer@chromium.org
BUG=chromium:651961
TEST=mjsunit/regress/wasm/regression-651961

Committed: https://crrev.com/2c12a9a42d454a36fcd2931fa458d72832eeb689
Cr-Commit-Position: refs/heads/master@{#39972}
==========

[commit-bot: I haz the power, 2016-10-05 06:07:08]

Patchset 2 (id:??) landed as
https://crrev.com/2c12a9a42d454a36fcd2931fa458d72832eeb689
Cr-Commit-Position: refs/heads/master@{#39972}

[ahaas, 2016-10-05 06:11:54]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2391223002/ by ahaas@chromium.org.

The reason for reverting is: Patch problem.

[ahaas, 2016-10-05 06:34:40]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 06:34:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-10-05 06:35:31]

ahaas@chromium.org changed reviewers:
+ gdeepti@chromium.org

[ahaas, 2016-10-05 06:37:15]

On 2016/10/05 at 06:11:54, ahaas wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2391223002/ by ahaas@chromium.org.
> 
> The reason for reverting is: Patch problem.

I adjusted the CL to the refactoring in
https://codereview.chromium.org/2396473003/ and added additional tests in
mjsunit/wasm/memory-size

[gdeepti, 2016-10-05 06:52:39]

lgtm

https://codereview.chromium.org/2386183004/diff/40001/src/wasm/wasm-module.cc
File src/wasm/wasm-module.cc (right):

https://codereview.chromium.org/2386183004/diff/40001/src/wasm/wasm-module.cc...
src/wasm/wasm-module.cc:1815: Handle<JSArrayBuffer> old_buffer;
s/old_buffer/buffer as this is still the buffer associated with the instance.

[commit-bot: I haz the power, 2016-10-05 07:05:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 07:05:27]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-10-05 08:38:56]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 08:39:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 09:07:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 09:07:52]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-10-05 09:09:36]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-10-05 09:09:36]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org,
gdeepti@chromium.org
Link to the patchset: https://codereview.chromium.org/2386183004/#ps60001
(title: "Comments addressed")

[commit-bot: I haz the power, 2016-10-05 09:09:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 09:12:01]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-05 09:12:16]

Description was changed from

==========
[wasm] Call a runtime function for a MemorySize instruction.

The implementation of MemorySize with RelocatableInt32Constants is
problematic if MemorySize is placed close to a GrowMemory instruction in
the code. The use of a runtime function guarantees that the order in
which MemorySize and GrowMemory is executed is correct.

R=titzer@chromium.org
BUG=chromium:651961
TEST=mjsunit/regress/wasm/regression-651961

Committed: https://crrev.com/2c12a9a42d454a36fcd2931fa458d72832eeb689
Cr-Commit-Position: refs/heads/master@{#39972}
==========

to

==========
[wasm] Call a runtime function for a MemorySize instruction.

The implementation of MemorySize with RelocatableInt32Constants is
problematic if MemorySize is placed close to a GrowMemory instruction in
the code. The use of a runtime function guarantees that the order in
which MemorySize and GrowMemory is executed is correct.

R=titzer@chromium.org
BUG=chromium:651961
TEST=mjsunit/regress/wasm/regression-651961

Committed: https://crrev.com/2c12a9a42d454a36fcd2931fa458d72832eeb689
Committed: https://crrev.com/aa93e6ca95123ccd176c392a2b5b8772ee5eb5c4
Cr-Original-Commit-Position: refs/heads/master@{#39972}
Cr-Commit-Position: refs/heads/master@{#39980}
==========

[commit-bot: I haz the power, 2016-10-05 09:12:19]

Patchset 4 (id:??) landed as
https://crrev.com/aa93e6ca95123ccd176c392a2b5b8772ee5eb5c4
Cr-Commit-Position: refs/heads/master@{#39980}