Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2386123006: Add a command line flag to disable streaming. (Closed)

Created:
4 years, 2 months ago by marja
Modified:
4 years, 2 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a command line flag to disable streaming. It's useful for debugging / analytics purposes, since we can force all parsing to happen on a foreground thread. BUG= Committed: https://crrev.com/1d40f81951d023229c53d5ce50ae1e2bd0978178 Cr-Commit-Position: refs/heads/master@{#39977}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/api.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Toon Verwaest
lgtm
4 years, 2 months ago (2016-10-05 08:10:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386123006/1
4 years, 2 months ago (2016-10-05 08:11:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 08:40:34 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 08:40:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d40f81951d023229c53d5ce50ae1e2bd0978178
Cr-Commit-Position: refs/heads/master@{#39977}

Powered by Google App Engine
This is Rietveld 408576698