Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2386123005: Support paths which are encoded with base64 in http put devfs server code (Closed)

Created:
4 years, 2 months ago by Cutch
Modified:
4 years, 2 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support paths which are encoded with base64 in http put devfs server code - [x] Add a new header 'dev_fs_path_b64' which is used over 'dev_fs_path' when present. - [x] 'dev_fs_path_b64' expects the path encoded as UTF8 and then BASE64. - [x] Add unit test case. BUG= R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/8b37da82ef98e2a57690e580d7335a49f07f0ca8

Patch Set 1 #

Patch Set 2 : add test #

Patch Set 3 : status file update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M runtime/bin/vmservice/server.dart View 1 chunk +10 lines, -2 lines 0 comments Download
A + runtime/observatory/tests/service/dev_fs_http_put_weird_char_test.dart View 1 3 chunks +5 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/service.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
4 years, 2 months ago (2016-10-04 22:23:00 UTC) #3
turnidge
lgtm
4 years, 2 months ago (2016-10-04 22:28:04 UTC) #4
Cutch
4 years, 2 months ago (2016-10-04 22:31:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
8b37da82ef98e2a57690e580d7335a49f07f0ca8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698