Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2386123004: Remove JavaFile.pathContext (Closed)

Created:
4 years, 2 months ago by Brian Wilkerson
Modified:
4 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -28 lines) Patch
M pkg/analyzer/lib/file_system/memory_file_system.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/java_io.dart View 6 chunks +13 lines, -15 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/java_io_test.dart View 2 chunks +9 lines, -8 lines 0 comments Download
M pkg/analyzer/test/utils.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Removed another place where tests can set the pathContext to a non-platform value.
4 years, 2 months ago (2016-10-04 02:26:36 UTC) #2
scheglov
LGTM
4 years, 2 months ago (2016-10-04 02:27:55 UTC) #3
Brian Wilkerson
4 years, 2 months ago (2016-10-04 02:28:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
29c5c9985e8badb990e4e05d17eb63482503c895 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698