Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3460)

Unified Diff: base/debug/task_annotator.cc

Issue 2386123003: Add heap allocator usage to task profiler. (Closed)
Patch Set: Figure out where the @#$%! corruption is coming from. Move heap tracking to TaskStopwatch." Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/debug/task_annotator.cc
diff --git a/base/debug/task_annotator.cc b/base/debug/task_annotator.cc
index 2747d63c2bf29aa3d356c8c750ff3784b943e66f..97d313af8450671084796db1ee4378743306bc44 100644
--- a/base/debug/task_annotator.cc
+++ b/base/debug/task_annotator.cc
@@ -31,6 +31,7 @@ void TaskAnnotator::RunTask(const char* queue_function,
const PendingTask& pending_task) {
ScopedTaskRunActivity task_activity(pending_task);
+ base::debug::HeapUsageTracker heap_usage;
Primiano Tucci (use gerrit) 2016/10/13 20:47:44 btw liked Scoped in the name, made it clear that
Sigurður Ásgeirsson 2016/10/14 20:11:35 Yeah, the problem is that the existing instrumenta
tracked_objects::TaskStopwatch stopwatch;
stopwatch.Start();
tracked_objects::Duration queue_duration =
@@ -54,6 +55,7 @@ void TaskAnnotator::RunTask(const char* queue_function,
pending_task.task.Run();
stopwatch.Stop();
+
Primiano Tucci (use gerrit) 2016/10/13 20:47:44 silly question: what's the point of this scoped He
Sigurður Ásgeirsson 2016/10/14 20:11:35 Good catch - I've moved the HUT into the StopWatch
tracked_objects::ThreadData::TallyRunOnNamedThreadIfTracking(
pending_task, stopwatch);
}

Powered by Google App Engine
This is Rietveld 408576698