Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2386103010: [test] Fix exception parsing in test262. (Closed)

Created:
4 years, 2 months ago by neis
Modified:
4 years, 2 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Fix exception parsing in test262. The _ParseException function in testcfg.py made incorrect assumptions about how exceptions are printed (I believe it expected a trace like that produced by Error). R=littledan@chromium.org BUG=v8:5136 Committed: https://crrev.com/194e418614e7db30fab0f5c7c91681abb67878ee Cr-Commit-Position: refs/heads/master@{#40078}

Patch Set 1 #

Patch Set 2 : Deal with --stress-opt output. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M test/test262/test262.status View 1 chunk +0 lines, -6 lines 0 comments Download
M test/test262/testcfg.py View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
neis
4 years, 2 months ago (2016-10-06 15:07:39 UTC) #1
neis
+adamk since Dan is away.
4 years, 2 months ago (2016-10-06 15:12:53 UTC) #4
adamk
lgtm if the tests like it
4 years, 2 months ago (2016-10-06 18:13:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386103010/1
4 years, 2 months ago (2016-10-07 07:59:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/builds/9984) v8_linux_nodcheck_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 2 months ago (2016-10-07 08:16:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2386103010/20001
4 years, 2 months ago (2016-10-07 10:18:48 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 10:20:50 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 10:21:18 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/194e418614e7db30fab0f5c7c91681abb67878ee
Cr-Commit-Position: refs/heads/master@{#40078}

Powered by Google App Engine
This is Rietveld 408576698