Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/build.py

Issue 2386103007: Fix GN build.py for Windows (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/build.py
diff --git a/tools/build.py b/tools/build.py
index 46f674cb0dc8afa136567242cd87047ac559a5c5..6c408e3b14b7425b3af472bd44591f6bbe0914fb 100755
--- a/tools/build.py
+++ b/tools/build.py
@@ -394,10 +394,13 @@ def NotifyBuildDone(build_config, success, start):
def RunGN(target_os, mode, arch):
- gn_command = ['tools/gn.py',
+ gn_os = 'host' if target_os == HOST_OS else target_os
+ gn_command = [
+ 'python',
+ os.path.join(DART_ROOT, 'tools', 'gn.py'),
'-m', mode,
'-a', arch,
- '--os', target_os,
+ '--os', gn_os,
'-v',
]
process = subprocess.Popen(gn_command)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698