Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_aura.h

Issue 2386103004: Ensure that we don't report huge mouse movement deltas for mouse enter and leave events. (Closed)
Patch Set: Update comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 406 matching lines...) Expand 10 before | Expand all | Expand 10 after
417 417
418 // Returns whether the widget needs to grab mouse capture to work properly. 418 // Returns whether the widget needs to grab mouse capture to work properly.
419 bool NeedsMouseCapture(); 419 bool NeedsMouseCapture();
420 420
421 // Confirm existing composition text in the webpage and ask the input method 421 // Confirm existing composition text in the webpage and ask the input method
422 // to cancel its ongoing composition session. 422 // to cancel its ongoing composition session.
423 void FinishImeCompositionSession(); 423 void FinishImeCompositionSession();
424 424
425 // This method computes movementX/Y and keeps track of mouse location for 425 // This method computes movementX/Y and keeps track of mouse location for
426 // mouse lock on all mouse move events. 426 // mouse lock on all mouse move events.
427 void ModifyEventMovementAndCoords(blink::WebMouseEvent* event); 427 // |event| contains the WebMouseEvent being modified.
428 // |ui_mouse_event| contains the mouse event received.
429 void ModifyEventMovementAndCoords(blink::WebMouseEvent* event,
430 ui::MouseEvent* ui_mouse_event);
428 431
429 // Sends an IPC to the renderer process to communicate whether or not 432 // Sends an IPC to the renderer process to communicate whether or not
430 // the mouse cursor is visible anywhere on the screen. 433 // the mouse cursor is visible anywhere on the screen.
431 void NotifyRendererOfCursorVisibilityState(bool is_visible); 434 void NotifyRendererOfCursorVisibilityState(bool is_visible);
432 435
433 // If |clip| is non-empty and and doesn't contain |rect| or |clip| is empty 436 // If |clip| is non-empty and and doesn't contain |rect| or |clip| is empty
434 // SchedulePaint() is invoked for |rect|. 437 // SchedulePaint() is invoked for |rect|.
435 void SchedulePaintIfNotInClip(const gfx::Rect& rect, const gfx::Rect& clip); 438 void SchedulePaintIfNotInClip(const gfx::Rect& rect, const gfx::Rect& clip);
436 439
437 // Helper method to determine if, in mouse locked mode, the cursor should be 440 // Helper method to determine if, in mouse locked mode, the cursor should be
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
679 // Allows tests to send gesture events for testing without first sending a 682 // Allows tests to send gesture events for testing without first sending a
680 // corresponding touch sequence, as would be required by 683 // corresponding touch sequence, as would be required by
681 // RenderWidgetHostInputEventRouter. 684 // RenderWidgetHostInputEventRouter.
682 bool disable_input_event_router_for_testing_; 685 bool disable_input_event_router_for_testing_;
683 686
684 // The routing and process IDs for the last RenderWidgetHost which had a 687 // The routing and process IDs for the last RenderWidgetHost which had a
685 // TextInputState of non-NONE. 688 // TextInputState of non-NONE.
686 int32_t last_active_widget_process_id_; 689 int32_t last_active_widget_process_id_;
687 int32_t last_active_widget_routing_id_; 690 int32_t last_active_widget_routing_id_;
688 691
692 // The last mouse move position. It is used as the location of subsequent
693 // mouse enter and leave events.
694 gfx::Point last_mouse_position_;
695
689 base::WeakPtrFactory<RenderWidgetHostViewAura> weak_ptr_factory_; 696 base::WeakPtrFactory<RenderWidgetHostViewAura> weak_ptr_factory_;
690 697
691 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewAura); 698 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewAura);
692 }; 699 };
693 700
694 } // namespace content 701 } // namespace content
695 702
696 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_ 703 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698