Source/devtools/front_end/ConsoleMessage.js - Issue 23861007: DevTools: Fix console output for native functions like Math.random

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/ConsoleMessage.js

Issue 23861007: DevTools: Fix console output for native functions like Math.random (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated test expectations Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/ConsoleMessage.js

diff --git a/Source/devtools/front_end/ConsoleMessage.js b/Source/devtools/front_end/ConsoleMessage.js

index abe81c9fdd56ec5603d1700c2e3a1f331eec597c..35a713b242f6e51548156ec3005965916a80fe5c 100644

--- a/Source/devtools/front_end/ConsoleMessage.js

+++ b/Source/devtools/front_end/ConsoleMessage.js

@@ -254,7 +254,8 @@ WebInspector.ConsoleMessageImpl.prototype = {

var lineNumber = callFrame.lineNumber ? callFrame.lineNumber - 1 : 0;

var columnNumber = callFrame.columnNumber ? callFrame.columnNumber - 1 : 0;

var rawLocation = new WebInspector.DebuggerModel.Location(callFrame.scriptId, lineNumber, columnNumber);

- return this._linkifier.linkifyRawLocation(rawLocation, "console-message-url");

+ var linkElement = this._linkifier.linkifyRawLocation(rawLocation, "console-message-url");

+ return linkElement ? linkElement : this._linkifyLocation(callFrame.url, callFrame.lineNumber, callFrame.columnNumber);

pfeldman 2013/09/05 11:42:10 I've seen this in another patch.

/**