Enable srcset support in HTMLImageElement

Source/core/html/parser/HTMLSrcsetParser.cpp

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "core/html/parser/HTMLSrcsetParser.h"
+
+#include "core/html/parser/HTMLParserIdioms.h"
+#include "core/platform/text/DecodeEscapeSequences.h"
+
+namespace WebCore {
+
+class ImageWithScale {
+    const String* m_source;
+    int m_start;
+    int m_length;

[abarth-chromium, 2013/09/13 22:24:06]

Instead of having a String*, a start, and a length, please use a StringView,
which combines these members into a class.

+    float m_scaleFactor;

[abarth-chromium, 2013/09/13 22:24:06]

Please place private declarations after the public declarations and begin the
section with the "private:" keyword.

+public:
+    ImageWithScale(const String* source, size_t start, size_t length, float scaleFactor)
+        : m_source(source)
+        , m_start(start)
+        , m_length(length)
+        , m_scaleFactor(scaleFactor)
+    {
+    }
+    bool operator==(const ImageWithScale& image) const
+    {
+        return m_scaleFactor == image.m_scaleFactor && m_source == image.m_source && m_length == image.m_length && m_start == image.m_start;
+    }
+    String toString() const

[abarth-chromium, 2013/09/13 22:24:06]

Please add blank lines between member functions.

+    {
+        return String(m_source->characters8() + m_start, m_length);

[abarth-chromium, 2013/09/13 22:24:06]

How do you know it's always 8 bits?  Anyway, StringView solves this problem for
you.

+    }
+    float scaleFactor() const
+    {
+        return m_scaleFactor;
+    }
+};
+typedef Vector<ImageWithScale> ImageCandidates;

[abarth-chromium, 2013/09/13 22:24:06]

Please add a blank line between top-level declarations.

I would remove this typedef.  It just makes the code harder to read.

+
+static inline bool compareByScaleFactor(const ImageWithScale& first, const ImageWithScale& second)
+{
+    return first.scaleFactor() < second.scaleFactor();
+}
+
+static inline bool isHTMLSpaceOrComma(UChar character)
+{
+    return isHTMLSpace(character) || character == ',';
+}

[abarth-chromium, 2013/09/13 22:24:06]

This function should got in HTMLParserIdioms.

+
+// See the specifications for more details about the algorithm to follow.

[abarth-chromium, 2013/09/13 22:24:06]

Please omit this line of the comment.  The second line, which links to the spec,
is helpful.

+// http://www.whatwg.org/specs/web-apps/current-work/multipage/embedded-content-1.html#processing-the-image-candidates
+static void parseImagesWithScaleFromSrcSetAttribute(const String& srcSetAttribute, ImageCandidates& imageCandidates)
+{
+    size_t imageCandidateStart = 0;

[abarth-chromium, 2013/09/13 22:24:06]

Lengths within strings are unsigned rather than size_t.  It's not possible to
have a String that's longer than unsigned.

+    unsigned srcSetLength = srcSetAttribute.length();
+
+    while (imageCandidateStart < srcSetLength) {
+        float imgScaleFactor = 1.0;
+        size_t separator;
+
+        // 4. Splitting loop: Skip whitespace.
+        size_t imageUrlStart = srcSetAttribute.find(isNotHTMLSpace, imageCandidateStart);
+        if (imageUrlStart == notFound)
+            break;
+        // If The current candidate is either totally empty or only contains space, skipping.
+        if (srcSetAttribute[imageUrlStart] == ',') {
+            imageCandidateStart = imageUrlStart + 1;
+            continue;
+        }
+        // 5. Collect a sequence of characters that are not space characters, and let that be url.
+        size_t imageUrlEnd = srcSetAttribute.find(isHTMLSpace, imageUrlStart + 1);
+        if (imageUrlEnd == notFound) {
+            imageUrlEnd = srcSetLength;
+            separator = srcSetLength;
+        } else if (srcSetAttribute[imageUrlEnd - 1] == ',') {
+            --imageUrlEnd;
+            separator = imageUrlEnd;
+        } else {
+            // 7. Collect a sequence of characters that are not "," (U+002C) characters, and let that be descriptors.
+            size_t imageScaleStart = srcSetAttribute.find(isNotHTMLSpace, imageUrlEnd + 1);
+            if (imageScaleStart == notFound) {
+                separator = srcSetLength;
+            } else if (srcSetAttribute[imageScaleStart] == ',') {
+                separator = imageScaleStart;
+            } else {
+                // This part differs from the spec as the current implementation only supports pixel density descriptors for now.
+                size_t imageScaleEnd = srcSetAttribute.find(isHTMLSpaceOrComma, imageScaleStart + 1);
+                imageScaleEnd = (imageScaleEnd == notFound) ? srcSetLength : imageScaleEnd;
+                size_t comma = imageScaleEnd;
+                // Make sure there are no other descriptors
+                while ((comma < srcSetLength - 1) && isHTMLSpace(srcSetAttribute[comma]))
+                    ++comma;
+                // If the first not html space character after the scale modifier is not a comma,
+                // the current candidate is an invalid input.
+                if ((comma < srcSetLength - 1) && srcSetAttribute[comma] != ',') {
+                    // Find the nearest comma and skip the input.
+                    comma = srcSetAttribute.find(',', comma + 1);
+                    if (comma == notFound)
+                        break;
+                    imageCandidateStart = comma + 1;
+                    continue;
+                }
+                separator = comma;
+                if (srcSetAttribute[imageScaleEnd - 1] != 'x') {
+                    imageCandidateStart = separator + 1;
+                    continue;
+                }
+                bool validScaleFactor = false;
+                size_t scaleFactorLengthWithoutUnit = imageScaleEnd - imageScaleStart - 1;
+                imgScaleFactor = charactersToFloat(srcSetAttribute.characters8() + imageScaleStart, scaleFactorLengthWithoutUnit, &validScaleFactor);
+
+                if (!validScaleFactor) {
+                    imageCandidateStart = separator + 1;
+                    continue;
+                }
+            }
+        }
+
+        imageCandidates.append(ImageWithScale(&srcSetAttribute, imageUrlStart, imageUrlEnd - imageUrlStart, imgScaleFactor));
+        // 11. Return to the step labeled splitting loop.
+        imageCandidateStart = separator + 1;
+    }
+}

[abarth-chromium, 2013/09/13 22:24:06]

This parsing algorithm is too hard to read.  It's also very inefficient because
it operates on Strings with offsets.  A better approach is to operate on UChar
or LChar pointers and use skipUntil / skipWhile / skipExactly functions as in
ContentSecurityPolicy.cpp.  I'd probably move those functions to a more general
location and change the explicit UChar type to a templated CharType.

The top-level branch in the parsing algorithm should be whether the String is 8
bits or 16 bits wide.  Then we can get either the UChar or the LChar pointer out
of the String and call the parsing algorithm, which is templated based on the
CharType.

In this approach, you don't need to juggle offsets and lengths.  You can just
use begin and end pointers, which you can subtract if you need lengths.  It's
also much easier to stay in the bounds of the string because the |end| pointers
are good fences.

+
+String bestFitSourceForImageAttributes(float deviceScaleFactor, const String& srcAttribute, const String& srcSetAttribute)
+{
+    ImageCandidates imageCandidates;
+
+    parseImagesWithScaleFromSrcSetAttribute(srcSetAttribute, imageCandidates);
+
+    const String src =  srcAttribute.simplifyWhiteSpace(isHTMLSpace);

[abarth-chromium, 2013/09/13 22:24:06]

You didn't address my previous review comments about this line.

Please address my previous review comments before uploading another patch and
asking me to review it.  It makes me feel like you don't respect my time when
you don't listen to my comments.  :(

+    if (!src.isEmpty()) {
+        imageCandidates.append(ImageWithScale(&srcAttribute, 0, src.length(), 1.0));
+    }

[abarth-chromium, 2013/09/13 22:24:06]

No need for { } for one-line if statements.

+
+    if (imageCandidates.isEmpty())
+        return String();
+
+    std::stable_sort(imageCandidates.begin(), imageCandidates.end(), compareByScaleFactor);
+
+    size_t i;
+    for (i = 0; i < imageCandidates.size() - 1; ++i) {
+        if (imageCandidates[i].scaleFactor() >= deviceScaleFactor)
+            break;
+    }
+    return imageCandidates[i].toString();
+}
+
+}