Source/core/html/parser/HTMLParserIdioms.cpp - Issue 23861003: Enable srcset support in HTMLImageElement

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/parser/HTMLParserIdioms.cpp

Issue 23861003: Enable srcset support in HTMLImageElement (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed issues raised in review. Merged Romain Perier's new parser implementation. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Apple Inc. All rights reserved.	2 * Copyright (C) 2010 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 278 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
289 bool threadSafeMatch(const QualifiedName& a, const QualifiedName& b)	289 bool threadSafeMatch(const QualifiedName& a, const QualifiedName& b)

290 {	290 {

291 return threadSafeEqual(a.localName().impl(), b.localName().impl());	291 return threadSafeEqual(a.localName().impl(), b.localName().impl());

292 }	292 }

293	293

294 bool threadSafeMatch(const HTMLIdentifier& localName, const QualifiedName& qName )	294 bool threadSafeMatch(const HTMLIdentifier& localName, const QualifiedName& qName )

295 {	295 {

296 return threadSafeEqual(localName.asStringImpl(), qName.localName().impl());	296 return threadSafeEqual(localName.asStringImpl(), qName.localName().impl());

297 }	297 }

298	298

	299
	abarth-chromium 2013/09/13 22:24:06 There's no need for this blank line. There's no need for this blank line.
299 }	300 }

OLD	NEW