Enable srcset support in HTMLImageElement

Source/core/html/parser/HTMLParserIdioms.h

 /*
  * Copyright (C) 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
@@ skipping 49 matching lines @@
 double parseToDoubleForNumberType(const String&, double fallbackValue);
 
 // http://www.whatwg.org/specs/web-apps/current-work/#rules-for-parsing-integers
 bool parseHTMLInteger(const String&, int&);
 
 // http://www.whatwg.org/specs/web-apps/current-work/#rules-for-parsing-non-negative-integers
 bool parseHTMLNonNegativeInteger(const String&, unsigned int&);
 
 // Inline implementations of some of the functions declared above.
 
-inline bool isHTMLSpace(UChar character)
+template<typename CharType>
+inline bool isHTMLSpace(CharType character)
 {
     // Histogram from Apple's page load test combined with some ad hoc browsing some other test suites.
     //
     //     82%: 216330 non-space characters, all > U+0020
     //     11%:  30017 plain space characters, U+0020
     //      5%:  12099 newline characters, U+000A
     //      2%:   5346 tab characters, U+0009
     //
     // No other characters seen. No U+000C or U+000D, and no other control characters.
     // Accordingly, we check for non-spaces first, then space, then newline, then tab, then the other characters.
 
     return character <= ' ' && (character == ' ' || character == '\n' || character == '\t' || character == '\r' || character == '\f');
 }
 
+inline bool isHTMLSpace(UChar character)
+{
+    return isHTMLSpace<UChar>(character);
+}

[abarth-chromium, 2013/09/19 18:09:52]

Why is this needed?

+
+template<typename CharType>
+inline bool isHTMLSpaceOrComma(CharType character)
+{
+    return isHTMLSpace(character) || character == ',';
+}
+
 inline bool isHTMLLineBreak(UChar character)
 {
     return character <= '\r' && (character == '\n' || character == '\r');
 }
 
 inline bool isNotHTMLSpace(UChar character)
 {
-    return !isHTMLSpace(character);
+    return !isHTMLSpace<UChar>(character);
+}

[abarth-chromium, 2013/09/19 18:09:52]

Why do you need these concrete specializations?

[Yoav Weiss, 2013/09/20 04:54:27]

I've added that to avoid changing the calls to isHTMLSpace all over the code. If
that's not a good idea, I can get rid of these specializations, and modify the
callers.

[abarth-chromium, 2013/09/20 16:08:07]

Most of the callers should be able to infer the type from the type of the
argument.

+
+template<typename CharType>
+inline bool isNotHTMLSpace(CharType character)
+{
+    return !isHTMLSpace<CharType>(character);
 }
 
 bool threadSafeMatch(const QualifiedName&, const QualifiedName&);
 bool threadSafeMatch(const HTMLIdentifier&, const QualifiedName&);
 inline bool threadSafeHTMLNamesMatch(const HTMLIdentifier& tagName, const QualifiedName& qName)
 {
     // When the QualifiedName is known to HTMLIdentifier,
     // all we have to do is a pointer compare.
     ASSERT(HTMLIdentifier::isKnown(qName.localName().impl()));
     return tagName.asStringImpl() == qName.localName().impl();
 }
 
 }
 
 #endif