Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1447)

Issue 23861002: Remove calls to HandleScope default ctor. (Closed)

Created:
7 years, 3 months ago by marja
Modified:
7 years, 3 months ago
Reviewers:
jamesr, szym, sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Visibility:
Public.

Description

Remove calls to HandleScope default ctor. It's replaced by a version which takes an isolate. The default ctor will be removed soon. BUG= R=jamesr@chromium.org, sky@chromium.org, szym@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221193

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M content/public/test/render_view_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/message_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/v8_var_converter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/v8_value_converter_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/proxy/proxy_resolver_v8.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
marja
james, sky, szym: ptal, here's some more V8 bindings related clean up. jamesr: content/renderer/browser_plugin/browser_plugin.cc content/renderer/pepper/message_channel.cc ...
7 years, 3 months ago (2013-09-02 08:53:38 UTC) #1
szym
net LGTM
7 years, 3 months ago (2013-09-02 19:52:28 UTC) #2
sky
LGTM
7 years, 3 months ago (2013-09-03 16:17:03 UTC) #3
jamesr
lgtm
7 years, 3 months ago (2013-09-03 21:23:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/marja@chromium.org/23861002/3001
7 years, 3 months ago (2013-09-04 06:48:34 UTC) #5
marja
7 years, 3 months ago (2013-09-04 16:11:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r221193 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698