Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: BUILD.gn

Issue 2386093003: Enable optimize max for arm in GN + update docs (Closed)
Patch Set: document is_asan=true Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | docs/deprecated_builds.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index fd8e231270110773c20d38c5a7ad3f4542fc41db..1765c13fdcd74b13741085d3a1b3d22902fe58fe 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -98,9 +98,11 @@ static_library("libyuv") {
deps += [ ":libyuv_msa" ]
}
- if (is_nacl) {
- # Always enable optimization under NaCl to workaround crbug.com/538243 .
+ # Always enable optimization for Release and NaCl builds (to workaround
+ # crbug.com/538243).
+ if (!is_debug || is_nacl) {
configs -= [ "//build/config/compiler:default_optimization" ]
+ # Enable optimize for speed (-O2) over size (-Os).
configs += [ "//build/config/compiler:optimize_max" ]
}
}
« no previous file with comments | « no previous file | docs/deprecated_builds.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698