Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: BUILD.gn

Issue 2386093003: Enable optimize max for arm in GN + update docs (Closed)
Patch Set: android builds documented Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | docs/deprecated_builds.md » ('j') | docs/getting_started.md » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index fd8e231270110773c20d38c5a7ad3f4542fc41db..ca3ae832ae28fe52cfb50aae35aa73821ab62600 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -98,8 +98,9 @@ static_library("libyuv") {
deps += [ ":libyuv_msa" ]
}
- if (is_nacl) {
- # Always enable optimization under NaCl to workaround crbug.com/538243 .
+ # Always enable optimization under NaCl to workaround crbug.com/538243 .
kjellander_chromium 2016/10/04 06:06:21 Change to: Always enable optimization for Release
fbarchard1 2016/10/04 18:23:45 Done.
+ # enable O2 and ltcg.
kjellander_chromium 2016/10/04 06:06:21 You might want to rephrase this to something like:
fbarchard1 2016/10/04 18:23:45 Done. Its not just for Windows. Arm release build
+ if (!is_debug || is_nacl) {
configs -= [ "//build/config/compiler:default_optimization" ]
configs += [ "//build/config/compiler:optimize_max" ]
}
« no previous file with comments | « no previous file | docs/deprecated_builds.md » ('j') | docs/getting_started.md » ('J')

Powered by Google App Engine
This is Rietveld 408576698