Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tools/perf/page_sets/system_health/loading_stories.py

Issue 2386083003: Add background stories to MobileSystemHealth (Closed)
Patch Set: use ScrollPageToElement Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/system_health/loading_stories.py
diff --git a/tools/perf/page_sets/system_health/loading_stories.py b/tools/perf/page_sets/system_health/loading_stories.py
index eae99f9b2fbeaf3b4a2f66685b4a1c9402ac815c..1f4232100545af925e712ed2d9d5bb0f3ae5181d 100644
--- a/tools/perf/page_sets/system_health/loading_stories.py
+++ b/tools/perf/page_sets/system_health/loading_stories.py
@@ -291,6 +291,7 @@ class _LoadGmailBaseStory(_LoadingStory):
# navigate to a sub-URL to set up the session and hit the resulting
# redirection loop. Afterwards, we can safely navigate to
# https://mail.google.com.
+ action_runner.tab.WaitForDocumentReadyStateToBeComplete()
action_runner.Navigate(
'https://mail.google.com/mail/mu/mp/872/trigger_redirection_loop')
action_runner.tab.WaitForDocumentReadyStateToBeComplete()
@@ -307,17 +308,6 @@ class LoadGmailDesktopStory(_LoadGmailBaseStory):
class LoadGmailMobileStory(_LoadGmailBaseStory):
SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
- def _DidLoadDocument(self, action_runner):
nednguyen 2016/10/18 14:37:26 What is this change about?
hjd 2016/10/21 16:17:22 The "Get Inbox by Gmail" interstitial no longer ap
- # Close the "Get Inbox by Gmail" interstitial.
- action_runner.WaitForJavaScriptCondition(
- 'document.querySelector("#isppromo a") !== null')
- action_runner.ExecuteJavaScript(
- 'document.querySelector("#isppromo a").click()')
- # Wait until the UI loads.
- action_runner.WaitForJavaScriptCondition(
- 'document.getElementById("apploadingdiv").style.height === "0px"')
-
-
class LoadMapsStory(_LoadingStory):
NAME = 'load:tools:maps'
URL = 'https://www.google.com/maps/place/London,+UK/'

Powered by Google App Engine
This is Rietveld 408576698