tools/perf/page_sets/system_health/background_stories.py - Issue 2386083003: Add background stories to MobileSystemHealth

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/page_sets/system_health/background_stories.py

Issue 2386083003: Add background stories to MobileSystemHealth (Closed)

Patch Set: use Background/Foreground methods Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 from page_sets.system_health import platforms

	6 from page_sets.system_health import system_health_story

	7

	8 class _BackgroundStory(system_health_story.SystemHealthStory):

	9 """Abstract base class for background stories

	10

	11 As a _LoadingStory except it puts the browser into the

	12 background before measuring.

	13 """

	14 ABSTRACT_STORY = True

	15 SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY

	16

	17 def _Measure(self, action_runner):

	18 action_runner.tab.browser.Background()
	nednguyen 2016/10/05 13:10:49 Should we wait few seconds after backgrounding to Should we wait few seconds after backgrounding to measure memory? perezju 2016/10/05 13:14:54 +1 Show quoted text On 2016/10/05 13:10:49, nednguyen wrote: > Should we wait few seconds after backgrounding to measure memory? +1 hjd 2016/10/05 13:45:44 Sounds good; 2 seconds? Show quoted text On 2016/10/05 13:14:54, perezju wrote: > On 2016/10/05 13:10:49, nednguyen wrote: > > Should we wait few seconds after backgrounding to measure memory? > > +1 Sounds good; 2 seconds?
	19 super(_BackgroundStory, self)._Measure(action_runner)

	20 action_runner.tab.browser.Foreground()
	nednguyen 2016/10/05 13:10:49 What happens if we don't foreground here? Would th What happens if we don't foreground here? Would the next telemetry test run fails? perezju 2016/10/05 13:14:54 I agree, we probably don't need to "Foreground" ag Show quoted text On 2016/10/05 13:10:49, nednguyen wrote: > What happens if we don't foreground here? Would the next telemetry test run > fails? I agree, we probably don't need to "Foreground" again; because the browser will be closed/restarted before going to the next page. hjd 2016/10/05 13:45:44 Yep the restart brings up the browser again :) Sha Show quoted text On 2016/10/05 13:14:54, perezju wrote: > On 2016/10/05 13:10:49, nednguyen wrote: > > What happens if we don't foreground here? Would the next telemetry test run > > fails? > > I agree, we probably don't need to "Foreground" again; because the browser will > be closed/restarted before going to the next page. Yep the restart brings up the browser again :) Shall I go ahead and remove this?
	21

	22

	23 class BackgroundGoogleStory(_BackgroundStory):

	24 NAME = 'background:search:google'

	25 URL = 'https://www.google.co.uk/'
	nednguyen 2016/10/05 13:10:50 Given that we only have around 5 single page stori Given that we only have around 5 single page stories for background, I am not sure whether we should pick google.co.uk perezju 2016/10/05 13:14:54 I'm coming up with a list of stories to pick. Will Show quoted text On 2016/10/05 13:10:50, nednguyen wrote: > Given that we only have around 5 single page stories for background, I am not > sure whether we should pick google.co.uk I'm coming up with a list of stories to pick. Will share it in a few more minutes.
	26

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »