Add background stories to MobileSystemHealth

tools/perf/benchmarks/system_health.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 
 from core import perf_benchmark
 from telemetry import benchmark
 from telemetry.timeline import chrome_trace_category_filter
 from telemetry.web_perf import timeline_based_measurement
@@ skipping 81 matching lines @@
 
   def CreateTimelineBasedMeasurementOptions(self):
     options = timeline_based_measurement.Options(
         chrome_trace_category_filter.ChromeTraceCategoryFilter(
             '-*,disabled-by-default-memory-infra'))
     options.config.enable_android_graphics_memtrack = True
     options.SetTimelineBasedMetrics(['memoryMetric'])
     return options
 
   def CreateStorySet(self, options):
-    return page_sets.SystemHealthStorySet(platform=self.PLATFORM,
-                                          take_memory_measurement=True)
+    measure_in_background = self.ShouldBackgroundChrome()
+    return page_sets.SystemHealthStorySet(
+        platform=self.PLATFORM,
+        take_memory_measurement=True,
+        measure_in_background=measure_in_background)
+
+  @classmethod
+  def ShouldBackgroundChrome(cls):
+    return False
 
   @classmethod
   def ShouldTearDownStateAfterEachStoryRun(cls):
     return True
 
   @classmethod
   def Name(cls):
-    return 'system_health.memory_%s' % cls.PLATFORM
+    if cls.ShouldBackgroundChrome():
+      return 'system_health.memory_%s_background' % cls.PLATFORM
+    else:
+      return 'system_health.memory_%s' % cls.PLATFORM

[perezju, 2016/10/05 13:14:54]

Instead of adding a new benchmark, I think we should add a new story group (or
groups), e.g. like the current browse:news or load:media, named maybe something
like background:news, background:media, etc.

[perezju, 2016/10/05 13:18:10]

Ignore that comment. Noise from a previous draft I never actually sent.

 
   @classmethod
   def ValueCanBeAddedPredicate(cls, value, is_first_result):
     # TODO(crbug.com/610962): Remove this stopgap when the perf dashboard
     # is able to cope with the data load generated by TBMv2 metrics.
     return not _IGNORED_STATS_RE.search(value.name)
 
 
 class DesktopMemorySystemHealth(_MemorySystemHealthBenchmark):
   """Desktop Chrome Memory System Health Benchmark."""
@@ skipping 12 matching lines @@
 
   @classmethod
   def ShouldDisable(cls, possible_browser):
     # http://crbug.com/612144
     if (possible_browser.browser_type == 'reference' and
         possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'):
       return True
 
     return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
 
+class MobileMemoryBackgroundSystemHealth(MobileMemorySystemHealth):
+  """Mobile Chrome Background Memory System Health Benchmark."""
+  PLATFORM = 'mobile'
+
+  @classmethod
+  def ShouldBackgroundChrome(cls):
+    return True
 
 @benchmark.Enabled('android-webview')
 class WebviewStartupSystemHealthBenchmark(perf_benchmark.PerfBenchmark):
   """Webview startup time benchmark
 
   Benchmark that measures how long WebView takes to start up
   and load a blank page. Since thie metric only requires the trace
   markers recorded in atrace, Chrome tracing is not enabled for this
   benchmark.
   """
@@ skipping 28 matching lines @@
   and load a blank page with multiprocess enabled.
   """
 
   def SetExtraBrowserOptions(self, options):
     options.AppendExtraBrowserArgs(
         ['--webview-sandboxed-renderer'])
 
   @classmethod
   def Name(cls):
     return 'system_health.webview_startup_multiprocess'