Added implicit empty password to 'presubmit_support.py'

Added implicit empty password to 'presubmit_support.py'

BUG=363477
TEST=localtest

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=263781

[nodir, 2014-04-15 03:16:47]

https://codereview.chromium.org/238603002/diff/1/presubmit_support.py
File presubmit_support.py (right):

https://codereview.chromium.org/238603002/diff/1/presubmit_support.py#newcode...
presubmit_support.py:1566: elif not options.rietveld_password:
I would be more explicit:
  options.rietveld_password is None

[ghost stip (do not use), 2014-04-15 03:21:39]

lgtm, but I'm not sure if it will work. I've made a suggestion below which may
be a better bet. if all else fails, revert

https://codereview.chromium.org/238603002/diff/1/presubmit_support.py
File presubmit_support.py (right):

https://codereview.chromium.org/238603002/diff/1/presubmit_support.py#newcode...
presubmit_support.py:1587: elif options.rietveld_private_key_file:
suggestion: we could do this if check first and if it fails, unconditionally do
lines 1583 and remove the else on line 1592:

if options.rietveld_private_key_file:
  rietveld_obj = rietveld.JwtOAuth2Rietveld(...)
else:
  rietveld_obj = rietveld.CachingRietveld(...)

this should preserve the old behavior

[nodir, 2014-04-15 03:59:37]

lgtm

[djacques1, 2014-04-15 04:00:31]

The CQ bit was checked by djacques@google.com

[commit-bot: I haz the power, 2014-04-15 04:00:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/djacques@chromium.org/238603002/20001

[commit-bot: I haz the power, 2014-04-15 04:02:33]

Change committed as 263781