Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 2385993002: Rewrap comments to 80 columns in Source/platform/image-decoders/. (Closed)

Created:
4 years, 2 months ago by Peter Kasting
Modified:
4 years, 2 months ago
Reviewers:
scroggo_chromium
CC:
chromium-reviews, blink-reviews, jzern, skal, urvang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rewrap comments to 80 columns in Source/platform/image-decoders/. This also rewrites some comments for clarity or brevity. BUG=563793 TEST=none Committed: https://crrev.com/e462f7cce1b45cc62a96abc33fe9961504c756d8 Cr-Commit-Position: refs/heads/master@{#422844}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rewrite comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -149 lines) Patch
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp View 7 chunks +18 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoderTest.cpp View 3 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageFrame.h View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp View 4 chunks +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.h View 6 chunks +16 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp View 1 15 chunks +58 lines, -45 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp View 7 chunks +23 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp View 3 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.cpp View 6 chunks +27 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp View 5 chunks +11 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Peter Kasting
4 years, 2 months ago (2016-10-01 07:37:06 UTC) #3
scroggo_chromium
lgtm https://codereview.chromium.org/2385993002/diff/1/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp (right): https://codereview.chromium.org/2385993002/diff/1/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp#newcode330 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp:330: // Performs decoding for this frame. frameDecoded will ...
4 years, 2 months ago (2016-10-04 15:36:00 UTC) #8
Peter Kasting
https://codereview.chromium.org/2385993002/diff/1/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp File third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp (right): https://codereview.chromium.org/2385993002/diff/1/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp#newcode330 third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp:330: // Performs decoding for this frame. frameDecoded will be ...
4 years, 2 months ago (2016-10-04 16:01:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385993002/20001
4 years, 2 months ago (2016-10-04 16:02:21 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 17:29:53 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 17:32:15 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e462f7cce1b45cc62a96abc33fe9961504c756d8
Cr-Commit-Position: refs/heads/master@{#422844}

Powered by Google App Engine
This is Rietveld 408576698