Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2385973002: Add TRACE_EVENT_SAMPLE_WITH_ID1 macro. (Closed)

Created:
4 years, 2 months ago by alph
Modified:
4 years, 2 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TRACE_EVENT_SAMPLE_WITH_ID1 macro. It is going to be used to record V8 CpuProfile events stream. BUG=406277 Committed: https://crrev.com/e15a4f7f9337276a79307d4210c3f6195e2a85d2 Cr-Commit-Position: refs/heads/master@{#422323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M base/trace_event/common/trace_event_common.h View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
alph
Primiano, could you please take a look.
4 years, 2 months ago (2016-10-01 02:11:07 UTC) #2
Primiano Tucci (use gerrit)
lgtm
4 years, 2 months ago (2016-10-01 07:47:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385973002/1
4 years, 2 months ago (2016-10-01 16:37:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-01 17:17:58 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e15a4f7f9337276a79307d4210c3f6195e2a85d2 Cr-Commit-Position: refs/heads/master@{#422323}
4 years, 2 months ago (2016-10-01 17:20:31 UTC) #12
fmeawad
4 years, 2 months ago (2016-10-03 15:24:51 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698