Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 2385943002: Revert of [wasm] further simplification of WasmCompiledModule (Closed)

Created:
4 years, 2 months ago by Mircea Trofin
Modified:
4 years, 2 months ago
Reviewers:
bradnelson, bradn
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] further simplification of WasmCompiledModule (patchset #1 id:1 of https://codereview.chromium.org/2381393002/ ) Reason for revert: Failures on multiple bots (e.g. https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/8887) Original issue's description: > [wasm] further simplification of WasmCompiledModule > > Calculate memory size from the available heap. This avoids > the bugs due to some numbers being stored as objects (by-ref) > and thus needing special handling when cloning. > > This leaves all the rest of the numbers as read-only. > > Further simplified by representing globals size as a Smi. > > BUG= > > Committed: https://crrev.com/7ced1bdc9df2315ccc07dd17c12736aebf40cb57 > Cr-Commit-Position: refs/heads/master@{#39923} TBR=bradnelson@google.com,bradnelson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/77b7be0c114ac491a710382ac9cfa456bd6a0bdc Cr-Commit-Position: refs/heads/master@{#39924}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -55 lines) Patch
M src/wasm/wasm-module.h View 3 chunks +37 lines, -17 lines 0 comments Download
M src/wasm/wasm-module.cc View 10 chunks +23 lines, -38 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mircea Trofin
Created Revert of [wasm] further simplification of WasmCompiledModule
4 years, 2 months ago (2016-10-01 00:05:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385943002/1
4 years, 2 months ago (2016-10-01 00:05:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-01 00:05:22 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-01 00:05:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77b7be0c114ac491a710382ac9cfa456bd6a0bdc
Cr-Commit-Position: refs/heads/master@{#39924}

Powered by Google App Engine
This is Rietveld 408576698