Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2385933002: DevTools: Make editingCommitted private (Closed)

Created:
4 years, 2 months ago by einbinder
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-style_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Make editingCommitted private BUG=none Committed: https://crrev.com/6ab0c6b878973f40e6bb587922d7854158c15a49 Cr-Commit-Position: refs/heads/master@{#422493}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
einbinder
ptal
4 years, 2 months ago (2016-10-01 00:00:49 UTC) #2
dgozman
lgtm
4 years, 2 months ago (2016-10-01 00:59:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385933002/1
4 years, 2 months ago (2016-10-03 18:18:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 19:34:19 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 19:37:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ab0c6b878973f40e6bb587922d7854158c15a49
Cr-Commit-Position: refs/heads/master@{#422493}

Powered by Google App Engine
This is Rietveld 408576698