Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Side by Side Diff: blimp/net/helium/helium_result.cc

Issue 2385913002: Define canonical enum for "HeliumResult" status values. (Closed)
Patch Set: the android compiler is dumb Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "blimp/net/helium/helium_result.h"
6
7 #include "base/logging.h"
8
9 namespace blimp {
10
11 const char* HeliumResultToString(HeliumResult result) {
12 switch (result) {
13 case HeliumResult::SUCCESS:
14 return "SUCCESS";
15 break;
16 #define HELIUM_ERROR(label, value) \
17 case HeliumResult::ERR_##label: \
18 return "ERR_" #label;
19 break;
Wez 2016/10/08 00:44:53 This break looks mis-placed, or unnecessary?
20 #include "blimp/net/helium/helium_errors.h"
21 #undef HELIUM_ERROR
22 }
23
24 NOTREACHED();
25 return "";
26 }
27
28 } // namespace blimp
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698