blimp/net/helium/helium_errors.h - Issue 2385913002: Define canonical enum for "HeliumResult" status values.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/net/helium/helium_errors.h

Issue 2385913002: Define canonical enum for "HeliumResult" status values. (Closed)

Patch Set: the android compiler is dumb Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // This file intentionally does not have header guards, it's included

	6 // inside a macro to generate enum values.

	7

	8 // This file contains the list of Helium error codes.

	9

	10 HELIUM_ERROR(INTERNAL_ERROR, 1)
	Wez 2016/10/08 00:44:53 nit: Should this be UNKNOWN_ERROR? i.e. it indicat nit: Should this be UNKNOWN_ERROR? i.e. it indicates some condition that we really never expected could possibly occur?
	11

	12 // The operation could not be performed because the connection to the peer was

	13 // lost.

	14 HELIUM_ERROR(DISCONNECTED, 2)

OLD	NEW