blimp/net/helium/helium_errors.h - Issue 2385913002: Define canonical enum for "HeliumResult" status values.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/net/helium/helium_errors.h

Issue 2385913002: Define canonical enum for "HeliumResult" status values. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // This file intentionally does not have header guards, it's included

	6 // inside a macro to generate enum values.

	7

	8 // This file contains the list of Helium error codes.

	9

	10 // A generic failure occurred.

	11 HELIUM_ERROR(FAILED, 1)
	Garrett Casto 2016/10/03 18:40:47 Nit: OK, FAILED, and CONNECTION_LOST were spelled Nit: OK, FAILED, and CONNECTION_LOST were spelled SUCCESS, INTERNAL_ERROR, and DISCONNECTED in the doc. I don't want to hold this up nit-picking the names (I haven't thought about them enough to know for certain which I think are better) but we might want to spend 15 minutes talking this out at some point. Getting good names is useful as they can be quite sticky. Kevin M 2016/10/03 22:32:19 OK, I'll add those. This CL is primarily about est Show quoted text On 2016/10/03 18:40:47, Garrett Casto wrote: > Nit: OK, FAILED, and CONNECTION_LOST were spelled SUCCESS, INTERNAL_ERROR, and > DISCONNECTED in the doc. I don't want to hold this up nit-picking the names (I > haven't thought about them enough to know for certain which I think are better) > but we might want to spend 15 minutes talking this out at some point. Getting > good names is useful as they can be quite sticky. OK, I'll add those. This CL is primarily about establishing a container for where to put the codes, and logic for stringifying the codes. Discussion about what might go in our error space could be a good teamwide topic.
	12

	13 // The operation could not be performed because the connection to the peer was

	14 // lost.

	15 HELIUM_ERROR(CONNECTION_LOST, 2)
	scf 2016/10/03 17:57:44 move the comment into a string? and use this for t move the comment into a string? and use this for the \|ToString\|? i.e. HELIUM_ERROR(FAILED, 1, "Generic failure occured") Kevin M 2016/10/03 22:32:19 That could be nice for logging, but I am a little Show quoted text On 2016/10/03 17:57:44, scf wrote: > move the comment into a string? and use this for the \|ToString\|? > > i.e. > HELIUM_ERROR(FAILED, 1, "Generic failure occured") That could be nice for logging, but I am a little wary that it could be used a crutch for half-assing enum value naming. And these are inherently not localizable, so we can't put them on the UI.
OLD	NEW

« no previous file with comments | « blimp/net/BUILD.gn ('k') | blimp/net/helium/helium_result.h » ('j') | blimp/net/helium/helium_result.h » ('J')