Create entrypoint to measure performance of the dart2js frontend

Create entrypoint to measure performance of the dart2js frontend

BUG=
R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/1324220ede6cabae468d42c6ccf38726c89ce3be

[Siggi Cherem (dart-lang), 2016-10-10 19:24:19]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2016-10-10 19:24:36]

sigmund@google.com changed reviewers:
+ het@google.com

[Harry Terkelsen, 2016-10-10 20:05:08]

lgtm

nice!

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
File pkg/compiler/tool/perf.dart (right):

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:8: import 'dart:io' show exit;
I remember we had some problems with exit and using --print-metrics with the VM.
Try running this entrypoint with --print-metrics and make sure that it works
correctly.

It looks like you only use it for the error case of bad arguments, so it should
be fine

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:11: import 'dart:io';
this makes the previous import redundant

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:23: 
sort these imports?

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:35: /// Cummulative total number of chars scanned.
Cumulative

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:38: /// Cummulative time spent scanning.
same

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:122: // Report size and scanning time again. See
discussion above.
I don't see a comment discussing this?

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:122: // Report size and scanning time again. See
discussion above.
maybe "see discussion in parseFiles"?

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:130: // The code below will record again how many
chars are scanned and how long it
move this comment to scanFiles?

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:147: var pTime = parseTimer.elapsedMicroseconds -
scanTimer.elapsedMicroseconds;
pTime -> parseTime?

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:176: listener.popNode();
why are you calling this?

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:277: Map _debug = {};
remove?

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:288: var file = _cache[resourceUri];
use putIfAbsent here

[Siggi Cherem (dart-lang), 2016-10-10 21:46:13]

thanks Harry!

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
File pkg/compiler/tool/perf.dart (right):

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:8: import 'dart:io' show exit;
On 2016/10/10 20:05:07, Harry Terkelsen wrote:
> I remember we had some problems with exit and using --print-metrics with the
VM.
> Try running this entrypoint with --print-metrics and make sure that it works
> correctly.
> 
> It looks like you only use it for the error case of bad arguments, so it
should
> be fine

Seems to still be an issue, but in this case it's ok :)

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:11: import 'dart:io';
On 2016/10/10 20:05:07, Harry Terkelsen wrote:
> this makes the previous import redundant

Done.

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:23: 
On 2016/10/10 20:05:07, Harry Terkelsen wrote:
> sort these imports?

Done.

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:35: /// Cummulative total number of chars scanned.
On 2016/10/10 20:05:07, Harry Terkelsen wrote:
> Cumulative

Done.

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:38: /// Cummulative time spent scanning.
On 2016/10/10 20:05:07, Harry Terkelsen wrote:
> same

Done.

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:122: // Report size and scanning time again. See
discussion above.
On 2016/10/10 20:05:07, Harry Terkelsen wrote:
> I don't see a comment discussing this?

good point - I added this later and the comment was initially just in parseFiles

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:122: // Report size and scanning time again. See
discussion above.
On 2016/10/10 20:05:07, Harry Terkelsen wrote:
> maybe "see discussion in parseFiles"?

Acknowledged.

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:130: // The code below will record again how many
chars are scanned and how long it
On 2016/10/10 20:05:07, Harry Terkelsen wrote:
> move this comment to scanFiles?

Done.

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:147: var pTime = parseTimer.elapsedMicroseconds -
scanTimer.elapsedMicroseconds;
On 2016/10/10 20:05:07, Harry Terkelsen wrote:
> pTime -> parseTime?

Done.

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:176: listener.popNode();
On 2016/10/10 20:05:07, Harry Terkelsen wrote:
> why are you calling this?

Ah - I meant to return the value (even though I don't use it above, it returns
the unit AST node)

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:277: Map _debug = {};
On 2016/10/10 20:05:07, Harry Terkelsen wrote:
> remove?

Done.

https://codereview.chromium.org/2385893002/diff/20001/pkg/compiler/tool/perf....
pkg/compiler/tool/perf.dart:288: var file = _cache[resourceUri];
On 2016/10/10 20:05:07, Harry Terkelsen wrote:
> use putIfAbsent here

Unfortunately I can't - the code that computes the value is async

[Siggi Cherem (dart-lang), 2016-10-10 21:47:34]

Description was changed from

==========
Create entrypoint to measure performance of the dart2js frontend

BUG=
==========

to

==========
Create entrypoint to measure performance of the dart2js frontend

BUG=
R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1324220ede6cabae468d42c6ccf38726c89ce3be
==========

[Siggi Cherem (dart-lang), 2016-10-10 21:47:36]

Committed patchset #2 (id:40001) manually as
1324220ede6cabae468d42c6ccf38726c89ce3be (presubmit successful).