Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 2385883002: [net] clang-format HttpNetworkTransactionTest.GenerateAuthToken test. (Closed)

Created:
4 years, 2 months ago by asanka
Modified:
4 years, 2 months ago
Reviewers:
mmenke
CC:
cbentzel+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[net] clang-format HttpNetworkTransactionTest.GenerateAuthToken test. This is a pretty big test with a lot of test cases. clang-format pretty much reformats the entire test beyond recognition. Subsequent patches that may touch this test will be unreviewable if they also include the formatting changes. Uploading the formatting changes separately. BUG=648366 Committed: https://crrev.com/c930761972fa8611069d0e55e3f45dd0c56c2d54 Cr-Commit-Position: refs/heads/master@{#422429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+450 lines, -137 lines) Patch
M net/http/http_network_transaction_unittest.cc View 2 chunks +450 lines, -137 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
asanka
mmenke: The only changes here are: 1. Get rid of kAuthErr in line 11279, and ...
4 years, 2 months ago (2016-09-30 22:51:10 UTC) #4
mmenke
On 2016/09/30 22:51:10, asanka wrote: > mmenke: > > The only changes here are: > ...
4 years, 2 months ago (2016-10-03 15:06:07 UTC) #7
mmenke
On 2016/10/03 15:06:07, mmenke wrote: > On 2016/09/30 22:51:10, asanka wrote: > > mmenke: > ...
4 years, 2 months ago (2016-10-03 15:06:26 UTC) #8
asanka
Thanks!
4 years, 2 months ago (2016-10-03 15:14:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2385883002/1
4 years, 2 months ago (2016-10-03 15:14:53 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 15:46:21 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 15:50:25 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c930761972fa8611069d0e55e3f45dd0c56c2d54
Cr-Commit-Position: refs/heads/master@{#422429}

Powered by Google App Engine
This is Rietveld 408576698