Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: chrome/browser/resources/settings/settings_ui/settings_ui.js

Issue 2385873002: MD Settings: preload Roboto bold to reduce flicker (Closed)
Patch Set: @override Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview 6 * @fileoverview
7 * 'settings-ui' implements the UI for the Settings page. 7 * 'settings-ui' implements the UI for the Settings page.
8 * 8 *
9 * Example: 9 * Example:
10 * 10 *
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 }, 98 },
99 passwordsAndForms: false, 99 passwordsAndForms: false,
100 downloads: { 100 downloads: {
101 googleDrive: false, 101 googleDrive: false,
102 }, 102 },
103 </if> 103 </if>
104 }; 104 };
105 } 105 }
106 }, 106 },
107 107
108 /** @override */
109 attached: function() {
110 document.fonts.load('bold 12px Roboto');
dpapad 2016/10/03 17:31:59 Perhaps add a short comment explaining why this is
Dan Beam 2016/10/03 19:26:48 Done.
111 },
112
108 /** 113 /**
109 * @param {Event} event 114 * @param {Event} event
110 * @private 115 * @private
111 */ 116 */
112 onIronActivate_: function(event) { 117 onIronActivate_: function(event) {
113 if (event.detail.item.id != 'advancedPage') 118 if (event.detail.item.id != 'advancedPage')
114 this.$$('app-drawer').close(); 119 this.$$('app-drawer').close();
115 }, 120 },
116 121
117 /** @private */ 122 /** @private */
118 onMenuButtonTap_: function() { 123 onMenuButtonTap_: function() {
119 this.$$('app-drawer').toggle(); 124 this.$$('app-drawer').toggle();
120 }, 125 },
121 126
122 /** @private */ 127 /** @private */
123 directionDelegateChanged_: function() { 128 directionDelegateChanged_: function() {
124 this.$$('app-drawer').align = this.directionDelegate.isRtl() ? 129 this.$$('app-drawer').align = this.directionDelegate.isRtl() ?
125 'right' : 'left'; 130 'right' : 'left';
126 }, 131 },
127 }); 132 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698